On Thu, Aug 08, 2024 at 01:25:47PM -0400, Robert Haas wrote:
> I wondered whether the regression tests actually hit the iovcnt == 2
> case, and it turns out that they do, rather frequently actually.
> Making that case a FATAL causes ~260 regression test failure. However,
> on larger systems, we'll
On Tue, Aug 6, 2024 at 6:30 PM Melih Mutlu wrote:
> Fixed.
+iov[0].iov_base = XLogCtl->pages + startidx * (Size)
XLOG_BLCKSZ;;
Double semicolon.
Aside from that, this looks correct now, so the next question is
whether we want it. To me, it seems like this isn't likely to buy ver
Hi Robert,
Thanks for reviewing.
Robert Haas , 6 Ağu 2024 Sal, 20:43 tarihinde şunu
yazdı:
> On Tue, Aug 6, 2024 at 5:36 AM Melih Mutlu wrote:
> > I think that we don't have the "contiguous pages" constraint when
> writing anymore as we can do vectored IO. It seems unnecessary to write
> just b
On Tue, Aug 6, 2024 at 5:36 AM Melih Mutlu wrote:
> I think that we don't have the "contiguous pages" constraint when writing
> anymore as we can do vectored IO. It seems unnecessary to write just because
> XLogWrite() is at the end of wal buffers.
> Attached patch uses pg_pwritev() instead of p
