Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2019-06-18 Thread Andres Freund
Hi, On 2018-12-17 15:35:01 -0800, Andres Freund wrote: > On 2018-12-16 13:48:00 -0800, Andres Freund wrote: > > On 2018-12-17 08:25:38 +1100, Thomas Munro wrote: > > > On Mon, Dec 17, 2018 at 7:57 AM Andres Freund wrote: > > > > The interesting bit is that if I replace the _exit(2) in > > > > bgw

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-17 Thread Andres Freund
Hi, On 2018-12-16 13:48:00 -0800, Andres Freund wrote: > Hi, > > On 2018-12-17 08:25:38 +1100, Thomas Munro wrote: > > On Mon, Dec 17, 2018 at 7:57 AM Andres Freund wrote: > > > The interesting bit is that if I replace the _exit(2) in > > > bgworker_quickdie() with an exit(2) (i.e. processing at

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-16 Thread Andres Freund
Hi, On 2018-12-17 08:25:38 +1100, Thomas Munro wrote: > On Mon, Dec 17, 2018 at 7:57 AM Andres Freund wrote: > > The interesting bit is that if I replace the _exit(2) in > > bgworker_quickdie() with an exit(2) (i.e. processing atexit handlers), > > or manully add an OPENSSL_cleanup() before the _

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-16 Thread Thomas Munro
On Mon, Dec 17, 2018 at 7:57 AM Andres Freund wrote: > The interesting bit is that if I replace the _exit(2) in > bgworker_quickdie() with an exit(2) (i.e. processing atexit handlers), > or manully add an OPENSSL_cleanup() before the _exit(2), valgrind > doesn't find errors. Weird. Well I can se

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-16 Thread Andres Freund
Hi, On 2018-12-16 22:33:00 +1100, Thomas Munro wrote: > On Fri, Dec 14, 2018 at 4:14 PM Tom Lane wrote: > > Andres Freund writes: > > > On December 13, 2018 6:01:04 PM PST, Tom Lane wrote: > > >> Has anyone tried to reproduce this on other platforms? > > > > > I recently also hit this locally,

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-16 Thread Thomas Munro
On Fri, Dec 14, 2018 at 4:14 PM Tom Lane wrote: > Andres Freund writes: > > On December 13, 2018 6:01:04 PM PST, Tom Lane wrote: > >> Has anyone tried to reproduce this on other platforms? > > > I recently also hit this locally, but since that's also Debian unstable... > > Note that removing op

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-13 Thread Tom Lane
Andres Freund writes: > On December 13, 2018 6:01:04 PM PST, Tom Lane wrote: >> Has anyone tried to reproduce this on other platforms? > I recently also hit this locally, but since that's also Debian unstable... > Note that removing openssl "fixed" the issue for me. FWIW, I tried to reproduce

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-13 Thread Thomas Munro
On Fri, Dec 14, 2018 at 1:15 PM Andres Freund wrote: > On December 13, 2018 6:01:04 PM PST, Tom Lane wrote: > >Thomas Munro writes: > >> Since libcrypto.so is implicated, Andres asked me off-list if my > >> changes to random number state initialisation might be linked to > >> skink's failures be

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-13 Thread Andres Freund
On December 13, 2018 6:01:04 PM PST, Tom Lane wrote: >Thomas Munro writes: >> Since libcrypto.so is implicated, Andres asked me off-list if my >> changes to random number state initialisation might be linked to >> skink's failures beginning 12 or 15 days ago. It appears not, as it >> was gree

Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit

2018-12-13 Thread Tom Lane
Thomas Munro writes: > Since libcrypto.so is implicated, Andres asked me off-list if my > changes to random number state initialisation might be linked to > skink's failures beginning 12 or 15 days ago. It appears not, as it > was green for several runs after that commit. > ... > It's Debian unst