Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-24 Thread Dave Page
Hi On Wed, Nov 24, 2021 at 11:36 AM Michael Paquier wrote: > On Wed, Nov 24, 2021 at 10:00:19AM +, Dave Page wrote: > > It's extremely unlikely that we'd shift to such a new version for PG15. > We > > build many components aside from PostgreSQL, and need to use the same > > toolchain for all

Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-24 Thread Michael Paquier
On Wed, Nov 24, 2021 at 10:00:19AM +, Dave Page wrote: > It's extremely unlikely that we'd shift to such a new version for PG15. We > build many components aside from PostgreSQL, and need to use the same > toolchain for all of them (we've had very painful experiences with mix n > match CRT vers

Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-24 Thread Dave Page
Hi On Wed, Nov 24, 2021 at 9:12 AM Hans Buschmann wrote: > Hello Michael, > > thanks for your hard work and quick response! > It is very convenient to only use VS2022 for Windows from now on... > > >Diff unrelated to your patch. > > Sorry for the copysoft problem from the first version. > > >Gla

Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-23 Thread Michael Paquier
On Sun, Nov 21, 2021 at 10:41:17AM +0900, Michael Paquier wrote: > I'll double-check your patch later, but that looks rather good to me. > Will try to apply and back-patch, and it would be better to check the > version numbers assigned in the patch, as well. I have spent a couple of hours on that

Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-20 Thread Michael Paquier
On Sat, Nov 20, 2021 at 05:54:30PM +, Hans Buschmann wrote: > My skills with git are minmal yet and I am working on a correct > development platform, so sorry for any inconveniances from my side. No need to worry here. We all learn all the time. I have been able to apply your patch with a "p

Re: VS2022: Support Visual Studio 2022 on Windows

2021-11-17 Thread Daniel Gustafsson
> On 6 Nov 2021, at 10:29, Hans Buschmann wrote: > Updated the patch to reflect the VisualStudioVersion for Preview 7, which is > the version number compiled into the main devenv.exe image. > This version number seems to be of no interest elsewhere in the postgres > source tree. This patch fa

Re: VS2022: Support Visual Studio 2022 on Windows

2021-10-10 Thread Michael Paquier
On Mon, Oct 04, 2021 at 08:21:52AM -0400, Andrew Dunstan wrote: > I think we'll want to wait for the official release before we add > support for it. Agreed. I am pretty sure that the version strings this patch is using are going to change until the release happens. -- Michael signature.asc Des

Re: VS2022: Support Visual Studio 2022 on Windows

2021-10-04 Thread Andrew Dunstan
On 10/4/21 6:13 AM, Laurenz Albe wrote: > On Fri, 2021-10-01 at 15:15 +, Hans Buschmann wrote: >> During testing of the new Visual Studio 2022 Preview Version 4.1 from >> Microsoft I also tried PG14.0 on it. >> The x64 version built without error!. >> >> Even when this is only a preview vers

Re: VS2022: Support Visual Studio 2022 on Windows

2021-10-04 Thread Laurenz Albe
On Fri, 2021-10-01 at 15:15 +, Hans Buschmann wrote: > During testing of the new Visual Studio 2022 Preview Version 4.1 from > Microsoft I also tried PG14.0 on it. > The x64 version built without error!. > > Even when this is only a preview version (the real thing is to expected soon) > it s