Re: User Interface for WAL usage data

2020-04-06 Thread Amit Kapila
On Mon, Apr 6, 2020 at 10:04 PM Justin Pryzby wrote: > > On Thu, Apr 02, 2020 at 08:29:31AM +0200, Julien Rouhaud wrote: > > > > "full page records" seems to be showing the number of full page > > > > images, not the record having full page images. > > > > > > I am not sure what exactly is a diffe

Re: User Interface for WAL usage data

2020-04-06 Thread Justin Pryzby
On Thu, Apr 02, 2020 at 08:29:31AM +0200, Julien Rouhaud wrote: > > > "full page records" seems to be showing the number of full page > > > images, not the record having full page images. > > > > I am not sure what exactly is a difference but it is the records > > having full page images. Julien c

Re: User Interface for WAL usage data

2020-04-03 Thread Julien Rouhaud
On Fri, Apr 3, 2020 at 11:58 AM Dilip Kumar wrote: > > On Fri, Apr 3, 2020 at 1:57 PM Amit Kapila wrote: > > > > On Fri, Apr 3, 2020 at 11:29 AM Amit Kapila wrote: > > > > > > On Fri, Apr 3, 2020 at 11:14 AM Justin Pryzby > > > wrote: > > > > > > > > On Fri, Apr 03, 2020 at 10:52:02AM +0530, A

Re: User Interface for WAL usage data

2020-04-03 Thread Dilip Kumar
On Fri, Apr 3, 2020 at 1:57 PM Amit Kapila wrote: > > On Fri, Apr 3, 2020 at 11:29 AM Amit Kapila wrote: > > > > On Fri, Apr 3, 2020 at 11:14 AM Justin Pryzby wrote: > > > > > > On Fri, Apr 03, 2020 at 10:52:02AM +0530, Amit Kapila wrote: > > > > On Fri, Apr 3, 2020 at 10:41 AM Justin Pryzby >

Re: User Interface for WAL usage data

2020-04-03 Thread Amit Kapila
On Fri, Apr 3, 2020 at 11:29 AM Amit Kapila wrote: > > On Fri, Apr 3, 2020 at 11:14 AM Justin Pryzby wrote: > > > > On Fri, Apr 03, 2020 at 10:52:02AM +0530, Amit Kapila wrote: > > > On Fri, Apr 3, 2020 at 10:41 AM Justin Pryzby > > > wrote: > > > > > > > > > > > > > >WAL: records=2359 full

Re: User Interface for WAL usage data

2020-04-02 Thread Amit Kapila
On Fri, Apr 3, 2020 at 11:14 AM Justin Pryzby wrote: > > On Fri, Apr 03, 2020 at 10:52:02AM +0530, Amit Kapila wrote: > > On Fri, Apr 3, 2020 at 10:41 AM Justin Pryzby wrote: > > > > > > > > > > > >WAL: records=2359 full page records=42 bytes=447788 > > > > > > 1) records; 2) pages ("full pag

Re: User Interface for WAL usage data

2020-04-02 Thread Justin Pryzby
On Fri, Apr 03, 2020 at 10:52:02AM +0530, Amit Kapila wrote: > On Fri, Apr 3, 2020 at 10:41 AM Justin Pryzby wrote: > > > > > > > > > >WAL: records=2359 full page records=42 bytes=447788 > > > > 1) records; 2) pages ("full page images"); 3) bytes > > > > That is exactly like sort (method/type/

Re: User Interface for WAL usage data

2020-04-02 Thread Amit Kapila
On Fri, Apr 3, 2020 at 10:41 AM Justin Pryzby wrote: > > > > > > > >WAL: records=2359 full page records=42 bytes=447788 > > 1) records; 2) pages ("full page images"); 3) bytes > > That is exactly like sort (method/type/size) and hash (buckets/batches/size), > and *not* like buffers, which show

Re: User Interface for WAL usage data

2020-04-02 Thread Justin Pryzby
> > > > > Regarding > > > > > v10-0004-Add-option-to-report-WAL-usage-in-EXPLAIN-and-au.patch: > > > > > I think there should be additional spaces before "full" and before > > > > > "bytes": > > > > > > > > > > >WAL: records=2359 full page records=42 bytes=447788 > > > > > > > > > > Compare w

Re: User Interface for WAL usage data

2020-04-02 Thread Amit Kapila
On Thu, Apr 2, 2020 at 12:05 PM Justin Pryzby wrote: > > On Thu, Apr 02, 2020 at 11:32:16AM +0530, Amit Kapila wrote: > > On Thu, Apr 2, 2020 at 11:28 AM Kyotaro Horiguchi > > wrote: > > > > > > At Thu, 2 Apr 2020 00:41:20 -0500, Justin Pryzby > > > wrote in > > > > Regarding > > > > v10-0004

Re: User Interface for WAL usage data

2020-04-01 Thread Justin Pryzby
On Thu, Apr 02, 2020 at 11:32:16AM +0530, Amit Kapila wrote: > On Thu, Apr 2, 2020 at 11:28 AM Kyotaro Horiguchi > wrote: > > > > At Thu, 2 Apr 2020 00:41:20 -0500, Justin Pryzby > > wrote in > > > Regarding v10-0004-Add-option-to-report-WAL-usage-in-EXPLAIN-and-au.patch: > > > I think there sh

Re: User Interface for WAL usage data

2020-04-01 Thread Julien Rouhaud
Thanks all for the feedback. On Thu, Apr 2, 2020 at 8:02 AM Amit Kapila wrote: > > On Thu, Apr 2, 2020 at 11:28 AM Kyotaro Horiguchi > wrote: > > > > At Thu, 2 Apr 2020 00:41:20 -0500, Justin Pryzby > > wrote in > > > On Thu, Apr 02, 2020 at 10:13:18AM +0530, Amit Kapila wrote: > > > > In thre

Re: User Interface for WAL usage data

2020-04-01 Thread Amit Kapila
On Thu, Apr 2, 2020 at 11:28 AM Kyotaro Horiguchi wrote: > > At Thu, 2 Apr 2020 00:41:20 -0500, Justin Pryzby wrote > in > > On Thu, Apr 02, 2020 at 10:13:18AM +0530, Amit Kapila wrote: > > > In thread [1], we are discussing to expose WAL usage data for each > > > statement in a way quite simila

Re: User Interface for WAL usage data

2020-04-01 Thread Kyotaro Horiguchi
At Thu, 2 Apr 2020 00:41:20 -0500, Justin Pryzby wrote in > On Thu, Apr 02, 2020 at 10:13:18AM +0530, Amit Kapila wrote: > > In thread [1], we are discussing to expose WAL usage data for each > > statement in a way quite similar to how we expose BufferUsage data. > > The way it exposes seems rea

Re: User Interface for WAL usage data

2020-04-01 Thread Justin Pryzby
On Thu, Apr 02, 2020 at 10:13:18AM +0530, Amit Kapila wrote: > In thread [1], we are discussing to expose WAL usage data for each > statement in a way quite similar to how we expose BufferUsage data. > The way it exposes seems reasonable to me and no one else raises any > objection. It could be th