Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"

2023-06-16 Thread Alvaro Herrera
On 2023-Jun-16, Masahiko Sawada wrote: > The walreceiver process doesn't use CRS_EXPORT_SNAPSHOT actually, > right? I think replacing it with CRS_EXPORT_SNAPSHOT would rather > confuse me libpqwalreceiver.c does use it. But I agree -- I think it would be better to not use the enum in walreceiver

Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"

2023-06-16 Thread Peter Smith
On Fri, Jun 16, 2023 at 6:17 PM Masahiko Sawada wrote: > > On Fri, Jun 16, 2023 at 3:10 PM Wei Wang (Fujitsu) > wrote: > > > > Hi, > > > > In the function WalReceiverMain, when the function walrcv_create_slot is > > called, > > the fourth parameter is assigned the value "0" instead of the enum v

Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"

2023-06-16 Thread Masahiko Sawada
On Fri, Jun 16, 2023 at 3:10 PM Wei Wang (Fujitsu) wrote: > > Hi, > > In the function WalReceiverMain, when the function walrcv_create_slot is > called, > the fourth parameter is assigned the value "0" instead of the enum value > "CRS_EXPORT_SNAPSHOT". I think it would be better to use the corres

Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"

2023-06-15 Thread Peter Smith
On Fri, Jun 16, 2023 at 4:10 PM Wei Wang (Fujitsu) wrote: > > Hi, > > In the function WalReceiverMain, when the function walrcv_create_slot is > called, > the fourth parameter is assigned the value "0" instead of the enum value > "CRS_EXPORT_SNAPSHOT". I think it would be better to use the corres