Richard Guo writes:
> Update the patch to include changes about righttree. But this doesn't
> include changes for edge case usages. (A rough look through shows to me
> that the current usages should be able to be covered by tests.)
I found a couple other places by grepping, and adjusted those too
On Wed, Jul 6, 2022 at 10:48 PM Tom Lane wrote:
> Typically, if one applies outerPlan() or outerPlanState() to the
> wrong pointer, the mistake will become obvious upon even minimal
> testing. My concern here is more about usages in edge cases that
> perhaps escape testing, for instance in the a
Richard Guo writes:
> On Sat, Jul 2, 2022 at 5:32 AM Tom Lane wrote:
>> Backing up a little bit, one thing not to like about the outerPlanState
>> and innerPlanState macros is that they lose all semblance of type
>> safety:
> Your concern makes sense. I think outerPlan and innerPlan macros share
Thanks for reviewing this patch.
On Sat, Jul 2, 2022 at 5:32 AM Tom Lane wrote:
> Richard Guo writes:
> > In the executor code, we mix use outerPlanState macro and referring to
> > leffttree. Commit 40f42d2a tried to keep the code consistent by
> > replacing referring to lefftree with outerPlan
Richard Guo writes:
> In the executor code, we mix use outerPlanState macro and referring to
> leffttree. Commit 40f42d2a tried to keep the code consistent by
> replacing referring to lefftree with outerPlanState macro, but there are
> still some outliers. This patch tries to clean them up.
Seems
