Re: Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places

2020-10-21 Thread David Rowley
On Fri, 16 Oct 2020 at 16:42, Hou, Zhijie wrote: > And after checking the code again and I found two more places which can be > improved. > > 1. > --- a/src/backend/parser/parse_expr.c > +++ b/src/backend/parser/parse_expr.c > @@ -1702,7 +1702,7 @@ transformMultiAssignRef(ParseState *pstate, > M

RE: Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places

2020-10-15 Thread Hou, Zhijie
> > I found some code places call list_delete_ptr can be replaced by > list_delete_xxxcell which can be faster. > > > > diff --git a/src/backend/optimizer/path/joinpath.c > > b/src/backend/optimizer/path/joinpath.c > > index db54a6b..61ef7c8 100644 > > --- a/src/backend/optimizer/path/joinpath.c >

Re: Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places

2020-10-15 Thread David Rowley
On Sat, 10 Oct 2020 at 15:45, Hou, Zhijie wrote: > I found some code places call list_delete_ptr can be replaced by > list_delete_xxxcell which can be faster. > > diff --git a/src/backend/optimizer/path/joinpath.c > b/src/backend/optimizer/path/joinpath.c > index db54a6b..61ef7c8 100644 > --- a/

Re: Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places

2020-10-14 Thread Luc Vlaming
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:not tested Patch applies cleanly on master & 13 and installcheck-world runs on 13 &