Re: Use boolean array for nulls parameters

2021-01-19 Thread japin
On Tue, 19 Jan 2021 at 23:45, Tom Lane wrote: > japin writes: >> When I review the [1], I find that the tuple's nulls array use char type. >> However there are many places use boolean array to repsent the nulls array, >> so I think we can replace the char type nulls array to boolean type. This

Re: Use boolean array for nulls parameters

2021-01-19 Thread Tom Lane
japin writes: > When I review the [1], I find that the tuple's nulls array use char type. > However there are many places use boolean array to repsent the nulls array, > so I think we can replace the char type nulls array to boolean type. This > change will break the SPI_xxx API, I'm not sure whe

Re: Use boolean array for nulls parameters

2021-01-19 Thread Hamid Akhtar
I personally don't see any benefit in this change. The focus shouldn't be on fixing things that aren't broken. Perhaps, there is more value in using bitmap data type to keep track of NULL values, which is typical storage vs performance debate, and IMHO, it's better to err on using slightly more sto