Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-12 Thread Junwang Zhao
On Fri, Jun 13, 2025 at 3:53 AM Nathan Bossart wrote: > > On Wed, Jun 11, 2025 at 07:35:39PM +0800, Junwang Zhao wrote: > > I have created a cf entry to track this. > > > > https://commitfest.postgresql.org/patch/5815/ > > I'll plan on committing this once v19 development begins. Sure, I just che

Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-12 Thread Nathan Bossart
On Wed, Jun 11, 2025 at 07:35:39PM +0800, Junwang Zhao wrote: > I have created a cf entry to track this. > > https://commitfest.postgresql.org/patch/5815/ I'll plan on committing this once v19 development begins. -- nathan

Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-11 Thread Junwang Zhao
Hi Ashutosh, On Wed, Jun 11, 2025 at 7:11 PM Ashutosh Bapat wrote: > > > > On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao wrote: >> >> Hi Nathan, >> >> On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart >> wrote: >> > >> > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote: >> > > All othe

Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-11 Thread Ashutosh Bapat
On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao wrote: > Hi Nathan, > > On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart > wrote: > > > > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote: > > > All other files perform this check using RELATION_IS_OTHER_TEMP. > > > Should we update tablec

Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-10 Thread Junwang Zhao
Hi Nathan, On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart wrote: > > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote: > > All other files perform this check using RELATION_IS_OTHER_TEMP. > > Should we update tablecmds.c to do the same for consistency? > > Seems like a good idea. Th

Re: Use RELATION_IS_OTHER_TEMP where possible

2025-06-10 Thread Nathan Bossart
On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote: > All other files perform this check using RELATION_IS_OTHER_TEMP. > Should we update tablecmds.c to do the same for consistency? Seems like a good idea. -- nathan