Re: Use PG_FINALLY to simplify code

2020-09-30 Thread Kyotaro Horiguchi
At Tue, 29 Sep 2020 23:10:52 -0400, Tom Lane wrote in tgl> Kyotaro Horiguchi writes: tgl> > At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie" wrote in tgl> >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify code here. tgl> tgl> > The patch removes PG_RETHROW(), w

Re: Use PG_FINALLY to simplify code

2020-09-29 Thread Tom Lane
Kyotaro Horiguchi writes: > At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie" > wrote in >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify >> code here. > The patch removes PG_RETHROW(), which is crucial in the code > path. No, that's not a problem, because PG_FI

Re: Use PG_FINALLY to simplify code

2020-09-29 Thread Kyotaro Horiguchi
At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie" wrote in > In (/src/pl/plpgsql/src/pl_exec.c), I found some code like the following: > > PG_CATCH(); > { > if (expr->plan && !expr->plan->saved) > expr->plan = NULL; > PG_RE_THROW();