Re: Update stale code comment in CheckpointerMain()

2021-12-01 Thread Robert Haas
On Wed, Dec 1, 2021 at 8:24 AM Daniel Gustafsson wrote: > >>> The attached patch updates the code comment which is no longer true > >>> after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd > >> Agreed, but looking at this shouldn't we also tweak the comment on > >> RecoveryInProgress() as per t

Re: Update stale code comment in CheckpointerMain()

2021-12-01 Thread Daniel Gustafsson
> On 1 Dec 2021, at 07:19, Amul Sul wrote: > > On Tue, Nov 30, 2021 at 3:09 PM Daniel Gustafsson wrote: >> >>> On 30 Nov 2021, at 08:00, Amul Sul wrote: >> >>> The attached patch updates the code comment which is no longer true >>> after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd >> >

Re: Update stale code comment in CheckpointerMain()

2021-11-30 Thread Amul Sul
On Tue, Nov 30, 2021 at 3:09 PM Daniel Gustafsson wrote: > > > On 30 Nov 2021, at 08:00, Amul Sul wrote: > > > The attached patch updates the code comment which is no longer true > > after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd > > Agreed, but looking at this shouldn't we also tweak th

Re: Update stale code comment in CheckpointerMain()

2021-11-30 Thread Daniel Gustafsson
> On 30 Nov 2021, at 08:00, Amul Sul wrote: > The attached patch updates the code comment which is no longer true > after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd Agreed, but looking at this shouldn't we also tweak the comment on RecoveryInProgress() as per the attached v2 diff? -- Dan