Re: Unordered wait event ClogGroupUpdate

2018-10-24 Thread Michael Paquier
On Wed, Oct 24, 2018 at 10:59:35AM +0530, Kuntal Ghosh wrote: > Nice. Same here. Thanks for confirming. I have committed the change, with HEAD making the structures and the documentation consistent. Down to 10, only the documentation has been changed, where it is adapted. -- Michael signature.

Re: Unordered wait event ClogGroupUpdate

2018-10-23 Thread Kuntal Ghosh
On Wed, Oct 24, 2018 at 10:48 AM Michael Paquier wrote: > > That's a valid argument. Additionally, I've found > > WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and > > WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a > > non-alphabetical order in WaitEventIPC enum. > And those ones are also incorr

Re: Unordered wait event ClogGroupUpdate

2018-10-23 Thread Michael Paquier
On Wed, Oct 24, 2018 at 10:25:37AM +0530, Kuntal Ghosh wrote: > That's a valid argument. Additionally, I've found > WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and > WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a > non-alphabetical order in WaitEventIPC enum. Indeed, thanks for double-checking

Re: Unordered wait event ClogGroupUpdate

2018-10-23 Thread Kuntal Ghosh
On Wed, Oct 24, 2018 at 5:56 AM Michael Paquier wrote: > baaf272 has added support for group updates in clog, however it has > added the wait event WAIT_EVENT_CLOG_GROUP_UPDATE in a non-alphabetical > order. There are many events, so keeping things in order helps users in > finding them. That's a