Re: Unlogged relations and WAL-logging

2023-09-15 Thread Heikki Linnakangas
On 01/09/2023 15:49, Peter Eisentraut wrote: Is the patch 0003-Remove-unnecessary-smgrimmedsync-when-creating-unlog.patch still relevant, or can this commitfest entry be closed? Yes. Pushed it now, thanks! -- Heikki Linnakangas Neon (https://neon.tech)

Re: Unlogged relations and WAL-logging

2023-09-01 Thread Peter Eisentraut
Is the patch 0003-Remove-unnecessary-smgrimmedsync-when-creating-unlog.patch still relevant, or can this commitfest entry be closed? On 23.08.23 16:40, Heikki Linnakangas wrote: 5. In heapam_relation_set_new_filenode(), we do this:     /* * If required, set up an init fork for

Re: Unlogged relations and WAL-logging

2023-08-23 Thread Heikki Linnakangas
On 07/07/2023 18:21, Heikki Linnakangas wrote: On 28/01/2022 15:57, Robert Haas wrote: 4. Also, the smgrwrite() calls are performed before WAL-logging the pages, so the page that's written to disk has 0/0 as the LSN, not the LSN of the WAL record. That's harmless too, but seems a bit sloppy. T

Re: Unlogged relations and WAL-logging

2023-07-07 Thread Heikki Linnakangas
On 28/01/2022 15:57, Robert Haas wrote: On Thu, Jan 27, 2022 at 2:32 PM Heikki Linnakangas wrote: Unlogged relations are not WAL-logged, but creating the init-fork is. There are a few things around that seem sloppy: 1. In index_build(), we do this: */ if (indexRelation->rd_rel

Re: Unlogged relations and WAL-logging

2022-01-28 Thread Robert Haas
On Thu, Jan 27, 2022 at 2:32 PM Heikki Linnakangas wrote: > Unlogged relations are not WAL-logged, but creating the init-fork is. > There are a few things around that seem sloppy: > > 1. In index_build(), we do this: > > >*/ > > if (indexRelation->rd_rel->relpersistence == RELPERSIST