Re: Understanding when VM record needs snapshot conflict horizon

2025-05-27 Thread Melanie Plageman
On Sun, May 25, 2025 at 6:45 AM Dilip Kumar wrote: > > IMHO, if we include snapshot conflict horizon in cases where it is not > necessary, don't you think it will impact performance on standby? > because now it has to loop through the procarray on standby to check > whether there is any conflict b

Re: Understanding when VM record needs snapshot conflict horizon

2025-05-25 Thread Dilip Kumar
On Sat, May 24, 2025 at 2:21 AM Melanie Plageman wrote: > > On Fri, May 23, 2025 at 12:04 PM Andres Freund wrote: > 3) if you are updating the VM and you are not modifying the heap page > at all, then you don't need to include a snapshot conflict horizon in > the record because you can safely as

Re: Understanding when VM record needs snapshot conflict horizon

2025-05-23 Thread Melanie Plageman
On Fri, May 23, 2025 at 12:04 PM Andres Freund wrote: > > > 2) if our inclusion of a cutoff_xid when freezing tuples is what makes > > it safe to omit it from the VM update, then wouldn't that be true if > > we included a cutoff_xid when pruning a page in a way that rendered it > > all-visible too

Re: Understanding when VM record needs snapshot conflict horizon

2025-05-23 Thread Andres Freund
Hi, On 2025-05-22 18:15:35 -0400, Melanie Plageman wrote: > I'm trying to understand when the visibility map WAL record > (xl_heap_visible) needs to include a snapshot conflict horizon. It needs to be included whenever replaying the WAL record could "break" an existing snapshot on the standby. E