Re: Two noncritical bugs of pg_waldump

2022-03-02 Thread Kyotaro Horiguchi
At Fri, 25 Feb 2022 10:48:47 -0800, Andres Freund wrote in > Hi, > > On 2022-02-14 18:18:47 +0900, Kyotaro Horiguchi wrote: > > > If I give an empty file to the tool it complains as the follows. > > > > > > > pg_waldump: fatal: could not read file "hoge": No such file or directory > > > > > >

Re: Two noncritical bugs of pg_waldump

2022-02-25 Thread Andres Freund
Hi, On 2022-02-14 18:18:47 +0900, Kyotaro Horiguchi wrote: > > If I give an empty file to the tool it complains as the follows. > > > > > pg_waldump: fatal: could not read file "hoge": No such file or directory > > > > No, the file exists. The cause is it reads uninitialized errno to > > detect

Re: Two noncritical bugs of pg_waldump

2022-02-14 Thread Kyotaro Horiguchi
Hmm.. At Thu, 27 Jan 2022 10:07:38 +0900 (JST), Kyotaro Horiguchi wrote in > pg_waldump complains at the end in any case. I noticed that the LSN > it shows in the finish message is incorrect. (I faintly thought that > I posted about this but I didn't find it..) > > > pg_waldump: fatal: error

Re: Two noncritical bugs of pg_waldump

2022-01-27 Thread Nathan Bossart
On Thu, Jan 27, 2022 at 01:27:36PM +0900, Kyotaro Horiguchi wrote: > At Thu, 27 Jan 2022 13:23:06 +0900 (JST), Kyotaro Horiguchi > wrote in >> So the issue there is neither EndRecPtr and ReadRecPtr always points >> to the current read LSN. The first proposal from Nathen was to use > > Mmm. Sorr

Re: Two noncritical bugs of pg_waldump

2022-01-27 Thread Nathan Bossart
On Thu, Jan 27, 2022 at 01:23:06PM +0900, Kyotaro Horiguchi wrote: > So the issue there is neither EndRecPtr and ReadRecPtr always points > to the current read LSN. The first proposal from Nathen was to use > currRecPtr but it was a private member. But after discussion, it > seems to me it is (at

Re: Two noncritical bugs of pg_waldump

2022-01-26 Thread Kyotaro Horiguchi
(this is off-topic) At Thu, 27 Jan 2022 13:23:06 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 26 Jan 2022 17:25:14 -0800, Nathan Bossart > wrote in > > On Thu, Jan 27, 2022 at 10:07:38AM +0900, Kyotaro Horiguchi wrote: > > > pg_waldump complains at the end in any case. I noticed that t

Re: Two noncritical bugs of pg_waldump

2022-01-26 Thread Kyotaro Horiguchi
At Wed, 26 Jan 2022 17:25:14 -0800, Nathan Bossart wrote in > On Thu, Jan 27, 2022 at 10:07:38AM +0900, Kyotaro Horiguchi wrote: > > pg_waldump complains at the end in any case. I noticed that the LSN > > it shows in the finish message is incorrect. (I faintly thought that > > I posted about t

Re: Two noncritical bugs of pg_waldump

2022-01-26 Thread Nathan Bossart
On Thu, Jan 27, 2022 at 10:07:38AM +0900, Kyotaro Horiguchi wrote: > pg_waldump complains at the end in any case. I noticed that the LSN > it shows in the finish message is incorrect. (I faintly thought that > I posted about this but I didn't find it..) Is this thread [0] what you are rememberin