Re: Toast compression method options

2021-10-01 Thread Dilip Kumar
On Fri, Oct 1, 2021 at 12:42 PM Michael Paquier wrote: > > On Mon, Sep 13, 2021 at 05:10:22PM +0530, Dilip Kumar wrote: > > I haved rebased the patch. > > Please note that the patch does not apply. FWIW, I still don't think > that this is a good idea to have that. I don't recall seeing much on >

Re: Toast compression method options

2021-10-01 Thread Michael Paquier
On Mon, Sep 13, 2021 at 05:10:22PM +0530, Dilip Kumar wrote: > I haved rebased the patch. Please note that the patch does not apply. FWIW, I still don't think that this is a good idea to have that. I don't recall seeing much on this list that users would like to have such a level of tuning for p

Re: Toast compression method options

2021-09-13 Thread Dilip Kumar
On Fri, Sep 10, 2021 at 9:54 PM Jaime Casanova wrote: > > I will do that early next week. > > > > Great! I'm marking the patch as "waiting on author". > Thanks for keep working on this. > I haved rebased the patch. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com From 167be9aa

Re: Toast compression method options

2021-09-10 Thread Jaime Casanova
On Fri, Sep 10, 2021 at 10:54:04AM +0530, Dilip Kumar wrote: > On Fri, 10 Sep 2021 at 10:40 AM, Jaime Casanova < > jcasa...@systemguards.com.ec> wrote: > > > On Mon, Jul 19, 2021 at 01:24:03PM +0530, Dilip Kumar wrote: > > > On Sun, Jul 18, 2021 at 9:15 PM Dilip Kumar > > wrote: > > > > > > > > O

Re: Toast compression method options

2021-09-09 Thread Dilip Kumar
On Fri, 10 Sep 2021 at 10:40 AM, Jaime Casanova < jcasa...@systemguards.com.ec> wrote: > On Mon, Jul 19, 2021 at 01:24:03PM +0530, Dilip Kumar wrote: > > On Sun, Jul 18, 2021 at 9:15 PM Dilip Kumar > wrote: > > > > > > On Wed, Jul 14, 2021 at 5:35 PM vignesh C wrote: > > > > > > > > On Thu, May

Re: Toast compression method options

2021-09-09 Thread Jaime Casanova
On Mon, Jul 19, 2021 at 01:24:03PM +0530, Dilip Kumar wrote: > On Sun, Jul 18, 2021 at 9:15 PM Dilip Kumar wrote: > > > > On Wed, Jul 14, 2021 at 5:35 PM vignesh C wrote: > > > > > > On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote > > > > > > The patch does not apply on Head anymore, could you

Re: Toast compression method options

2021-07-19 Thread Dilip Kumar
On Sun, Jul 18, 2021 at 9:15 PM Dilip Kumar wrote: > > On Wed, Jul 14, 2021 at 5:35 PM vignesh C wrote: > > > > On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote > > > > The patch does not apply on Head anymore, could you rebase and post a > > patch. I'm changing the status to "Waiting for Author

Re: Toast compression method options

2021-07-18 Thread Dilip Kumar
On Wed, Jul 14, 2021 at 5:35 PM vignesh C wrote: > > On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote > > The patch does not apply on Head anymore, could you rebase and post a > patch. I'm changing the status to "Waiting for Author". Okay, I will rebase and send it by next week. -- Regards, Di

Re: Toast compression method options

2021-07-14 Thread Dilip Kumar
On Tue, Jun 22, 2021 at 1:37 PM Michael Paquier wrote: > > On Tue, Jun 22, 2021 at 11:05:22AM +0530, Dilip Kumar wrote: > > IMHO there is certainly a use case, basically, if we compress the data > > so that we can avoid storing it externally. Now suppose for some > > data, with default LZ4 compre

Re: Toast compression method options

2021-07-14 Thread vignesh C
On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote: > > On Mon, May 3, 2021 at 6:27 PM Dilip Kumar wrote: > > > > We have already pushed the configurable lz4 toast compression code[1]. > > In the custom compression thread, we were already having the patch to > > support the compression method optio

Re: Toast compression method options

2021-06-22 Thread Michael Paquier
On Tue, Jun 22, 2021 at 11:05:22AM +0530, Dilip Kumar wrote: > IMHO there is certainly a use case, basically, if we compress the data > so that we can avoid storing it externally. Now suppose for some > data, with default LZ4 compression, the compression ratio is so high > that you are able to com

Re: Toast compression method options

2021-06-21 Thread Dilip Kumar
On Fri, Jun 18, 2021 at 12:13 PM Michael Paquier wrote: > > On Thu, May 06, 2021 at 07:23:48PM +0530, Dilip Kumar wrote: > > I have fixed some comments offlist reported by Justin. Apart from > > that, I have also improved documentation and test case. Stil it has a > > lot of cleanup to be done b

Re: Toast compression method options

2021-06-17 Thread Michael Paquier
On Thu, May 06, 2021 at 07:23:48PM +0530, Dilip Kumar wrote: > I have fixed some comments offlist reported by Justin. Apart from > that, I have also improved documentation and test case. Stil it has a > lot of cleanup to be done but I am not planning to do that > immediately. I was testing the v

Re: Toast compression method options

2021-05-06 Thread Dilip Kumar
On Mon, May 3, 2021 at 6:27 PM Dilip Kumar wrote: > > We have already pushed the configurable lz4 toast compression code[1]. > In the custom compression thread, we were already having the patch to > support the compression method options[2]. But the design for the > base patches was heavily modif