Re: Time to put context diffs in the grave

On 06/19/2018 05:45 PM, Peter Geoghegan wrote: On Tue, Jun 19, 2018 at 2:41 PM, Tom Lane wrote: Not requiring them is considerably different from actually trying to stamp them out. To my mind, where we're trying to go here is not having one set of people impose their diff format preferences

Re: Time to put context diffs in the grave

On Tue, Jun 19, 2018 at 2:41 PM, Tom Lane wrote: > Not requiring them is considerably different from actually trying > to stamp them out. To my mind, where we're trying to go here is > not having one set of people impose their diff format preferences > on other people. Am I the only one that doe

Re: Time to put context diffs in the grave

On 2018-06-19 17:41:00 -0400, Tom Lane wrote: > Andrew Dunstan writes: > > On 06/19/2018 05:21 PM, Andres Freund wrote: > >> Given that we've "officially" stopped relying on context diffs, > >> I don't see why we'd not also retire them in pg_regress. > > > Well I suspect at least one person would

Re: Time to put context diffs in the grave

Andrew Dunstan writes: > On 06/19/2018 05:21 PM, Andres Freund wrote: >> Given that we've "officially" stopped relying on context diffs, >> I don't see why we'd not also retire them in pg_regress. > Well I suspect at least one person would be made unhappy ;-) Not requiring them is considerably d

Re: Time to put context diffs in the grave

On 06/19/2018 05:21 PM, Andres Freund wrote: Given that we've "officially" stopped relying on context diffs, I don't see why we'd not also retire them in pg_regress. Well I suspect at least one person would be made unhappy ;-) cheers andrew -- Andrew Dunstanhttps://www.

Re: Time to put context diffs in the grave

On 2018-06-19 17:18:32 -0400, Andrew Dunstan wrote: > On 06/19/2018 04:54 PM, Andres Freund wrote: > > Could we please also change pg_regress' diff invocations? I find it > > really painful to see differences in buildfarm output due to the > > -C3. Locally I've long exported PG_REGRESS_DIFF_OPTS, b

Re: Time to put context diffs in the grave

On 06/19/2018 04:54 PM, Andres Freund wrote: Hi, On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: We haven't insisted on context diffs in years now, and one of my interlocutors has just turned handsprings trying to follow the advice at t

Re: Time to put context diffs in the grave

Hi, On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: > > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice at > to produce his first > patch. > > > Unles

Re: Time to put context diffs in the grave

On Wed, May 23, 2018 at 05:01:58PM -0400, Tom Lane wrote: > Andrew Dunstan writes: > > OK, that's done. Now I think we can get rid of git-external-diff. > > I for one rely on that. I won't tell anyone else what kind of diff > they have to read, but if you try to tell me what kind of diff I have

Re: Time to put context diffs in the grave

On Wed, May 23, 2018 at 5:01 PM, Tom Lane wrote: > Andrew Dunstan writes: >> OK, that's done. Now I think we can get rid of git-external-diff. > > I for one rely on that. I won't tell anyone else what kind of diff > they have to read, but if you try to tell me what kind of diff I have > to read,

Re: Time to put context diffs in the grave

Andrew Dunstan writes: > OK, that's done. Now I think we can get rid of git-external-diff. I for one rely on that. I won't tell anyone else what kind of diff they have to read, but if you try to tell me what kind of diff I have to read, I'm going to complain. > While we're about it, does anyone

Re: Time to put context diffs in the grave

On Mon, May 21, 2018 at 10:52 PM, Andres Freund wrote: > Hi, > > On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: >> We haven't insisted on context diffs in years now, and one of my >> interlocutors has just turned handsprings trying to follow the advice at >>

Re: Time to put context diffs in the grave

On Tue, May 22, 2018 at 06:59:56PM +0900, Kyotaro HORIGUCHI wrote: > filterdiff has a bug that we can lose a part of hunks with it, > and I actually have stepped on it. I saw Álvaro made a complaint > about the bug but it doesn't seem to have been fixed. It is the > most major reason I'm posting pa

Re: Time to put context diffs in the grave

At Mon, 21 May 2018 21:51:11 -0400, Andrew Dunstan wrote in <247f4d65-31f3-d426-2b24-fc434fa67...@2ndquadrant.com> > > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice > at

Re: Time to put context diffs in the grave

On Mon, May 21, 2018 at 09:51:11PM -0400, Andrew Dunstan wrote: > Unless someone objects really violently I'm going to rip all that stuff out > and let sanity prevail. Please! -- Michael signature.asc Description: PGP signature

Re: Time to put context diffs in the grave

On Mon, May 21, 2018 at 09:51:11PM -0400, Andrew Dunstan wrote: > > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice at > to produce his first > patch. > > U

Re: Time to put context diffs in the grave

Hi, On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice at > to produce his first > patch. > > > Unless s