On Wed, Jun 27, 2018 at 11:30 AM, Ashutosh Bapat
wrote:
> On Wed, Jun 27, 2018 at 11:24 AM, Amit Kapila wrote:
>>>
>>> I don't understand what do you mean by consistent. Do you mean to say
>>> that current usage " Store the slot into tuple ... " is correct?
>>>
>>
>> Oh no, I was talking about r
On Wed, Jun 27, 2018 at 11:24 AM, Amit Kapila wrote:
>>
>> I don't understand what do you mean by consistent. Do you mean to say
>> that current usage " Store the slot into tuple ... " is correct?
>>
>
> Oh no, I was talking about replacing it with below comment which is
> used at other places in
On Wed, Jun 27, 2018 at 10:09 AM, Ashutosh Bapat
wrote:
> On Tue, Jun 26, 2018 at 8:43 PM, Amit Kapila wrote:
>> On Tue, Jun 26, 2018 at 7:02 PM, Ashutosh Bapat
>> wrote:
>>> On Tue, Jun 26, 2018 at 6:18 PM, Amit Kapila
>>> wrote:
On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
wrot
On Tue, Jun 26, 2018 at 8:43 PM, Amit Kapila wrote:
> On Tue, Jun 26, 2018 at 7:02 PM, Ashutosh Bapat
> wrote:
>> On Tue, Jun 26, 2018 at 6:18 PM, Amit Kapila wrote:
>>> On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
>>> wrote:
Looks like we need similar adjustment in ExecSimpleRelationUp
On Tue, Jun 26, 2018 at 7:02 PM, Ashutosh Bapat
wrote:
> On Tue, Jun 26, 2018 at 6:18 PM, Amit Kapila wrote:
>> On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
>> wrote:
>>> Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
>>> well. Updated the patch.
>>>
>>
>> - /* Store t
On Tue, Jun 26, 2018 at 6:18 PM, Amit Kapila wrote:
> On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
> wrote:
>> Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
>> well. Updated the patch.
>>
>
> - /* Store the slot into tuple that we can write. */
> + /* Materialize slot
On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
wrote:
> Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
> well. Updated the patch.
>
- /* Store the slot into tuple that we can write. */
+ /* Materialize slot into a tuple that we can inspect. */
tuple = ExecMaterializeSlo
Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
well. Updated the patch.
On Tue, Jun 26, 2018 at 3:12 PM, Ashutosh Bapat
wrote:
> Hi,
> There seems to be a thinko/typo in ExecSimpleRelationInsert(). A tuple
> can never store a slot, but a comment in that function says so. T
