Re: TAP tests still sensitive to various PG* environment variables

2021-06-02 Thread Michael Paquier
On Wed, Jun 02, 2021 at 10:39:56AM +0200, Daniel Gustafsson wrote: > Seems like a good idea, to keep test invocation stable across branches, minus > PGSSLCRLDIR and PGSSLSNI which are only available in HEAD etc. Right. This took me a couple of hours to make consistent across all the branches. Af

Re: TAP tests still sensitive to various PG* environment variables

2021-06-02 Thread Michael Paquier
On Wed, Jun 02, 2021 at 03:43:46PM -0400, Andrew Dunstan wrote: > Let's change it to something like: > > my @scrubkeys = qw ( PGCHANNELBINDING >    PGCLIENTENCODING PGCONNECT_TIMEOUT PGDATA >    ... >     ); > delete @ENV{@scrubkeys}; Good idea. I have used that. Thanks. -- M

Re: TAP tests still sensitive to various PG* environment variables

2021-06-02 Thread Andrew Dunstan
On 6/1/21 9:49 PM, Michael Paquier wrote: > Hi all, > > While looking at a separate issue, I have noticed that TestLib.pm is > lagging behind in terms of environment variables it had better mask to > avoid failures: > https://www.postgresql.org/message-id/ylxjfov3teapi...@paquier.xyz > > Once I b

Re: TAP tests still sensitive to various PG* environment variables

2021-06-02 Thread Daniel Gustafsson
> On 2 Jun 2021, at 03:49, Michael Paquier wrote: > Attached is a patch to strengthen all that, which I think we'd better > backpatch. +1 > Any objections to that? Seems like a good idea, to keep test invocation stable across branches, minus PGSSLCRLDIR and PGSSLSNI which are only available in