Re: TAP tests for pg_verify_checksums

2018-10-11 Thread Michael Paquier
On Wed, Oct 10, 2018 at 10:50:02AM +0900, Michael Paquier wrote: > The resulting patch is attached. Does that look good? And committed. Thanks all for taking the time to review. -- Michael signature.asc Description: PGP signature

Re: TAP tests for pg_verify_checksums

2018-10-09 Thread Michael Paquier
On Tue, Oct 09, 2018 at 05:14:50PM +0200, Michael Banck wrote: > Am Dienstag, den 09.10.2018, 16:54 +0200 schrieb Peter Eisentraut: >> On 06/10/2018 13:46, Michael Paquier wrote: > >>> +# Time to create a corruption > > That looks a bit weird, maybe "some corruption"? Or maybe it's just me > not

Re: TAP tests for pg_verify_checksums

2018-10-09 Thread Michael Banck
Hi, Am Dienstag, den 09.10.2018, 16:54 +0200 schrieb Peter Eisentraut: > On 06/10/2018 13:46, Michael Paquier wrote: > > What do you think about the updated version attached? > > +# Time to create a corruption That looks a bit weird, maybe "some corupption"? Or maybe it's just me not being a nat

Re: TAP tests for pg_verify_checksums

2018-10-09 Thread Peter Eisentraut
On 06/10/2018 13:46, Michael Paquier wrote: > On Fri, Oct 05, 2018 at 01:38:05PM +0200, Michael Banck wrote: >> It's too late for v11 though at this point I guess? > > Unfortunately yes. > >> I think it would be easy to also test the -r command-line option, as we >> already create a table. > > G

Re: TAP tests for pg_verify_checksums

2018-10-06 Thread Michael Paquier
On Fri, Oct 05, 2018 at 01:38:05PM +0200, Michael Banck wrote: > It's too late for v11 though at this point I guess? Unfortunately yes. > I think it would be easy to also test the -r command-line option, as we > already create a table. Good idea. Let's add this test. > That comment should read

Re: TAP tests for pg_verify_checksums

2018-10-05 Thread Michael Banck
Hi, On Fri, Oct 05, 2018 at 10:26:45AM +0900, Michael Paquier wrote: > The topic of $subject has been discussed a bit times, resulting in a > couple of patches on the way: > https://www.postgresql.org/message-id/20180830200258.gg15...@paquier.xyz > https://www.postgresql.org/message-id/cabuevezekr