Re: TAP tests aren't using the magic words for Windows file access

Thank you very much! On 2020-12-15 20:47, Andrew Dunstan wrote: On 12/15/20 12:05 AM, r.zhar...@postgrespro.ru wrote: Are there any plans to backport the patch to earlier versions of the Postgres? https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210be

Re: TAP tests aren't using the magic words for Windows file access

On 12/15/20 12:05 AM, r.zhar...@postgrespro.ru wrote: > Hello hackers, > > Are there any plans to backport the patch to earlier versions > of the Postgres? > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210beaab43 > > > We rarely see the issue with

Re: TAP tests aren't using the magic words for Windows file access

Hello hackers, Are there any plans to backport the patch to earlier versions of the Postgres? https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210beaab43 We rarely see the issue with the pg_ctl/004_logrotate test on the REL_12_STABLE branch. On my note

Re: TAP tests aren't using the magic words for Windows file access

On 11/24/19 6:46 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 11/22/19 3:46 PM, Tom Lane wrote: >>> Andrew Dunstan writes: I think the best course is for us to give your latest patch an outing on the buildfarm and verify that the issues seen with slurp_file disappear. That

Re: TAP tests aren't using the magic words for Windows file access

Andrew Dunstan writes: > On 11/22/19 3:46 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> I think the best course is for us to give your latest patch an outing on >>> the buildfarm and verify that the issues seen with slurp_file disappear. >>> That shouldn't take us more than a week or two to s

Re: TAP tests aren't using the magic words for Windows file access

On 11/22/19 3:46 PM, Tom Lane wrote: > Andrew Dunstan writes: >> I think the best course is for us to give your latest patch an outing on >> the buildfarm and verify that the issues seen with slurp_file disappear. >> That shouldn't take us more than a week or two to see - drongo has had 6 >> suc

Re: TAP tests aren't using the magic words for Windows file access

Andrew Dunstan writes: > I think the best course is for us to give your latest patch an outing on > the buildfarm and verify that the issues seen with slurp_file disappear. > That shouldn't take us more than a week or two to see - drongo has had 6 > such failures in the last 11 days on master. Aft

Re: TAP tests aren't using the magic words for Windows file access

On 11/22/19 3:55 AM, Juan José Santamaría Flecha wrote: > > On Fri, Nov 22, 2019 at 9:00 AM Michael Paquier > wrote: > > On Thu, Nov 21, 2019 at 08:09:38PM +0100, Juan José Santamaría > Flecha wrote: > > I think Perl's open() is a bad candidate for an over

Re: TAP tests aren't using the magic words for Windows file access

On Fri, Nov 22, 2019 at 9:00 AM Michael Paquier wrote: > On Thu, Nov 21, 2019 at 08:09:38PM +0100, Juan José Santamaría Flecha > wrote: > > I think Perl's open() is a bad candidate for an overload, so I will > update > > the previous patch that only touches slurp_file(). > > FWIW, I don't like mu

Re: TAP tests aren't using the magic words for Windows file access

On Thu, Nov 21, 2019 at 08:09:38PM +0100, Juan José Santamaría Flecha wrote: > I think Perl's open() is a bad candidate for an overload, so I will update > the previous patch that only touches slurp_file(). FWIW, I don't like much the approach of patching only slurp_file(). What gives us the guara

Re: TAP tests aren't using the magic words for Windows file access

On Thu, Nov 21, 2019 at 3:35 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > On 11/20/19 3:40 PM, Thomas Munro wrote: > > On Fri, Nov 8, 2019 at 3:41 AM Andrew Dunstan > > wrote: > >> On 11/7/19 9:12 AM, Alvaro Herrera wrote: > The patch says: > > +require Wi

Re: TAP tests aren't using the magic words for Windows file access

On 11/20/19 3:40 PM, Thomas Munro wrote: > On Fri, Nov 8, 2019 at 3:41 AM Andrew Dunstan > wrote: >> On 11/7/19 9:12 AM, Alvaro Herrera wrote: The patch says: +require Win32::API; +Win32::API->import; >>> Oh, you're right, it does. I wonder why, though: >>> >

Re: TAP tests aren't using the magic words for Windows file access

On Fri, Nov 8, 2019 at 3:41 AM Andrew Dunstan wrote: > On 11/7/19 9:12 AM, Alvaro Herrera wrote: > >> > >> The patch says: > >> > >> +require Win32::API; > >> +Win32::API->import; > > Oh, you're right, it does. I wonder why, though: > > > > On further inspection I think those line

Re: TAP tests aren't using the magic words for Windows file access

On 11/7/19 9:12 AM, Alvaro Herrera wrote: >> >> The patch says: >> >> +        require Win32::API; >> +        Win32::API->import; > Oh, you're right, it does. I wonder why, though: > On further inspection I think those lines are unnecessary. The remainder of the patch doesn't use this at all,

Re: TAP tests aren't using the magic words for Windows file access

On 11/7/19 9:12 AM, Alvaro Herrera wrote: > On 2019-Nov-07, Andrew Dunstan wrote: > >> On 11/7/19 8:53 AM, Alvaro Herrera wrote: >>> That's a curious test to try, given that the module is called >>> Win32API::File. >> The patch says: >> >> +        require Win32::API; >> +        Win32::API->impo

Re: TAP tests aren't using the magic words for Windows file access

On 2019-Nov-07, Andrew Dunstan wrote: > On 11/7/19 8:53 AM, Alvaro Herrera wrote: > > That's a curious test to try, given that the module is called > > Win32API::File. > > The patch says: > > +        require Win32::API; > +        Win32::API->import; Oh, you're right, it does. I wonder why,

Re: TAP tests aren't using the magic words for Windows file access

On 11/7/19 8:53 AM, Alvaro Herrera wrote: > On 2019-Nov-07, Andrew Dunstan wrote: > >> The test I'm running is: >> >>     perl -MWin32::API -e ';' >> >> And perl reports it can't find the module. > That's a curious test to try, given that the module is called > Win32API::File. > The patch says:

Re: TAP tests aren't using the magic words for Windows file access

On 2019-Nov-07, Andrew Dunstan wrote: > The test I'm running is: > >     perl -MWin32::API -e ';' > > And perl reports it can't find the module. That's a curious test to try, given that the module is called Win32API::File. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreS

Re: TAP tests aren't using the magic words for Windows file access

On 11/7/19 3:42 AM, Juan José Santamaría Flecha wrote: > > On Thu, Nov 7, 2019 at 1:57 AM Andrew Dunstan > > wrote: > > > In any case, the patch will fail as written - on the Msys 1 system I > just tested Win32::API is not available to the DTK perl

Re: TAP tests aren't using the magic words for Windows file access

On Thu, Nov 7, 2019 at 1:57 AM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > In any case, the patch will fail as written - on the Msys 1 system I > just tested Win32::API is not available to the DTK perl we need to use > to run TAP tests. > > May I ask which version of Msys is that s

Re: TAP tests aren't using the magic words for Windows file access

On Thu, Nov 07, 2019 at 11:13:32AM +1300, Thomas Munro wrote: > Not a Windows or Perl person, but I see that you can redefine core > functions with *CORE::GLOBAL::open = , if you > wanted to make a version of open() that does that FILE_SHARE_READ > dance. FWIW, I would have gone with a solution li

Re: TAP tests aren't using the magic words for Windows file access

On 11/6/19 4:43 PM, Tom Lane wrote: > =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= > writes: >> Please find attached a patch that adds the FILE_SHARE options to >> TestLib::slurp_file using Win32API::File. > Ick. Are we going to need Windows-droppings like this all over the > TAP tests?

Re: TAP tests aren't using the magic words for Windows file access

On Thu, Nov 7, 2019 at 10:43 AM Tom Lane wrote: > =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= > writes: > > Please find attached a patch that adds the FILE_SHARE options to > > TestLib::slurp_file using Win32API::File. > > Ick. Are we going to need Windows-droppings like this all over the

Re: TAP tests aren't using the magic words for Windows file access

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= writes: > Please find attached a patch that adds the FILE_SHARE options to > TestLib::slurp_file using Win32API::File. Ick. Are we going to need Windows-droppings like this all over the TAP tests? I'm not sure I believe that slurp_file is the o

Re: TAP tests aren't using the magic words for Windows file access

On Wed, Nov 6, 2019 at 4:38 PM Alvaro Herrera wrote: > On 2019-Nov-05, Michael Paquier wrote: > > > On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote: > > > That is, TestLib::slurp_file is failing to read a file. Almost > > > certainly, "permission denied" doesn't really mean a permission

Re: TAP tests aren't using the magic words for Windows file access

On 2019-Nov-05, Michael Paquier wrote: > On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote: > > That is, TestLib::slurp_file is failing to read a file. Almost > > certainly, "permission denied" doesn't really mean a permissions > > problem, but failure to specify the file-opening flags nee

Re: TAP tests aren't using the magic words for Windows file access

On 11/4/19 10:41 PM, Michael Paquier wrote: > On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote: >> That is, TestLib::slurp_file is failing to read a file. Almost >> certainly, "permission denied" doesn't really mean a permissions >> problem, but failure to specify the file-opening flags

Re: TAP tests aren't using the magic words for Windows file access

On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote: > That is, TestLib::slurp_file is failing to read a file. Almost > certainly, "permission denied" doesn't really mean a permissions > problem, but failure to specify the file-opening flags needed to > allow concurrent access on Windows. We