Re: Speeding Up Bitmapset

2023-06-25 Thread David Rowley
On Mon, 26 Jun 2023 at 12:55, Ranier Vilela wrote: > > Em dom., 25 de jun. de 2023 às 17:49, David Rowley > escreveu: >> >> There's no reason in the world >> that those will speed up Bitmapsets, so why include them? > > Of course optimization is the most important thing, > but since you're going

Re: Speeding Up Bitmapset

2023-06-25 Thread David Rowley
On Mon, 26 Jun 2023 at 12:55, Ranier Vilela wrote: > Have you seen bms_compare? > For some reason someone thought it would be better to loop backward the array. That's nothing to do with efficiency. It's related to behaviour. Have a look at the function's header comment, it's trying to find the s

Re: Speeding Up Bitmapset

2023-06-25 Thread Ranier Vilela
Em dom., 25 de jun. de 2023 às 17:49, David Rowley escreveu: > There's no reason in the world > that those will speed up Bitmapsets, so why include them? > Of course optimization is the most important thing, but since you're going to touch the source, why not make it more readable. > > > v7 out

Re: Speeding Up Bitmapset

2023-06-25 Thread David Rowley
On Mon, 26 Jun 2023 at 00:29, Ranier Vilela wrote: > Yuya Watari presented a series of patches, with the objective of improving > the Bitmapset [1]. > After reading through the patches, I saw a lot of good ideas and thought I'd > help. > Unfortunately, my suggestions were not well received. For