Re: Some doubious code in pgstat.c

2020-11-08 Thread Kyotaro Horiguchi
At Fri, 6 Nov 2020 16:40:39 +0530, Amit Kapila wrote in > On Thu, Nov 5, 2020 at 2:13 PM Kyotaro Horiguchi > wrote: > > > > At Thu, 5 Nov 2020 11:48:24 +0530, Amit Kapila > > wrote in > > > On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada > > > wrote: > > > > > > > > On Thu, Nov 5, 2020 at 11

Re: Some doubious code in pgstat.c

2020-11-06 Thread Amit Kapila
On Thu, Nov 5, 2020 at 2:13 PM Kyotaro Horiguchi wrote: > > At Thu, 5 Nov 2020 11:48:24 +0530, Amit Kapila > wrote in > > On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada > > wrote: > > > > > > On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi > > > wrote: > > > > As another issue, just replace

Re: Some doubious code in pgstat.c

2020-11-05 Thread Amit Kapila
On Thu, Nov 5, 2020 at 2:13 PM Kyotaro Horiguchi wrote: > > At Thu, 5 Nov 2020 11:48:24 +0530, Amit Kapila > wrote in > > On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada > > wrote: > > > > > > On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi > > > wrote: > > > > As another issue, just replace

Re: Some doubious code in pgstat.c

2020-11-05 Thread Kyotaro Horiguchi
At Thu, 5 Nov 2020 11:48:24 +0530, Amit Kapila wrote in > On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada wrote: > > > > On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi > > wrote: > > > As another issue, just replace memcpy with strlcpy makes compiler > > > complain of type mismatch, as the f

Re: Some doubious code in pgstat.c

2020-11-04 Thread Amit Kapila
On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada wrote: > > On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi > wrote: > > As another issue, just replace memcpy with strlcpy makes compiler > > complain of type mismatch, as the first paramter to memcpy had an > > needless "&" operator. I removed it

Re: Some doubious code in pgstat.c

2020-11-04 Thread Masahiko Sawada
On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi wrote: > > At Wed, 4 Nov 2020 22:49:57 +0900, Masahiko Sawada > wrote in > > On Wed, Nov 4, 2020 at 6:49 PM Amit Kapila wrote: > > > > > > On Wed, Nov 4, 2020 at 2:25 PM Kyotaro Horiguchi > > > wrote: > > > > > > > > Hello. > > > > > > > > Whil

Re: Some doubious code in pgstat.c

2020-11-04 Thread Kyotaro Horiguchi
At Wed, 4 Nov 2020 22:49:57 +0900, Masahiko Sawada wrote in > On Wed, Nov 4, 2020 at 6:49 PM Amit Kapila wrote: > > > > On Wed, Nov 4, 2020 at 2:25 PM Kyotaro Horiguchi > > wrote: > > > > > > Hello. > > > > > > While updating a patch, I noticed that the replication slot stats > > > patch (9868

Re: Some doubious code in pgstat.c

2020-11-04 Thread Masahiko Sawada
On Wed, Nov 4, 2020 at 6:49 PM Amit Kapila wrote: > > On Wed, Nov 4, 2020 at 2:25 PM Kyotaro Horiguchi > wrote: > > > > Hello. > > > > While updating a patch, I noticed that the replication slot stats > > patch (9868167500) put some somewhat doubious codes. > > > > In pgstat_recv_replslot, an ass

Re: Some doubious code in pgstat.c

2020-11-04 Thread Amit Kapila
On Wed, Nov 4, 2020 at 2:25 PM Kyotaro Horiguchi wrote: > > Hello. > > While updating a patch, I noticed that the replication slot stats > patch (9868167500) put some somewhat doubious codes. > > In pgstat_recv_replslot, an assertion like the following exists: > > > idx = pgstat_replslot_ind