Re: Snapshot scalability patch issue

2021-02-15 Thread Peter Geoghegan
On Mon, Feb 15, 2021 at 5:30 PM Andres Freund wrote: > Done. Thanks for noticing/reporting! Great, thanks! -- Peter Geoghegan

Re: Snapshot scalability patch issue

2021-02-15 Thread Andres Freund
Hi, On 2021-02-15 15:08:40 -0800, Andres Freund wrote: > On 2021-02-14 18:42:18 -0800, Peter Geoghegan wrote: > > The call to heap_page_prune() within lazy_scan_heap() passes a bool > > literal ('false') as its fourth argument. But the fourth argument is > > of type TransactionId, not bool. This h

Re: Snapshot scalability patch issue

2021-02-15 Thread Andres Freund
Hi, On 2021-02-14 18:42:18 -0800, Peter Geoghegan wrote: > The call to heap_page_prune() within lazy_scan_heap() passes a bool > literal ('false') as its fourth argument. But the fourth argument is > of type TransactionId, not bool. This has been the case since the > snapshot scalability work perf