Re: Small code cleanup

2020-06-01 Thread Mark Dilger
> On Jun 1, 2020, at 9:59 AM, Tom Lane wrote: > > Mark Dilger writes: >> Yeah, I noticed the `git blame` last night when writing the patch that you >> had originally wrote the code around 2017, and that the duplication was >> introduced in a patch committed by others around 2018. I was hop

Re: Small code cleanup

2020-06-01 Thread Tom Lane
Mark Dilger writes: > Yeah, I noticed the `git blame` last night when writing the patch that you > had originally wrote the code around 2017, and that the duplication was > introduced in a patch committed by others around 2018. I was hoping that > you, as the original author, or somebody invol

Re: Small code cleanup

2020-06-01 Thread Mark Dilger
> On Jun 1, 2020, at 8:53 AM, Tom Lane wrote: > > Mark Dilger writes: >> One line change to remove a duplicate check. > > The comment just above this mentions a connection to the "Finish printing > the footer information about a table" stanza below. I think some work is > needed to clarify

Re: Small code cleanup

2020-06-01 Thread Tom Lane
Mark Dilger writes: > One line change to remove a duplicate check. The comment just above this mentions a connection to the "Finish printing the footer information about a table" stanza below. I think some work is needed to clarify what's going on there --- it doesn't seem actually buggy, but th