On Mon, Aug 4, 2025 at 2:07 AM Shlok Kyal wrote:
>
...
> > 10b.
> > How does "ALTER PUBLICATION tap_pub_col SET
> > (publish_generated_columns)" even work? I thought the
> > "pubish_generated_columns" is an enum but you did not specify any enum
> > value here (???)
> >
> > ~~~
> Yes, it works. It
On Wed, 23 Jul 2025 at 10:08, shveta malik wrote:
>
> I further tested inherited tables flow as well wrt ONLY and EXCEPT, it
> works well. But while reading docs for the saem, I have few concerns.
>
> 1)
> While explaining ONLY for EXCEPT, create-publication doc says this
>
> + This does not
On Tue, 22 Jul 2025 at 15:57, shveta malik wrote:
>
> Shlok, I was trying to validate the interaction of
> 'publish_via_partition_root' with 'EXCEPT". Found some unexpected
> behaviour, can you please review:
>
> Pub:
> -
> CREATE TABLE tab_root (range_col int,i int,j int) PARTITION BY RAN
On Tue, 22 Jul 2025 at 14:29, shveta malik wrote:
>
> On Sat, Jul 19, 2025 at 4:17 PM Shlok Kyal wrote:
> >
> > On Mon, 30 Jun 2025 at 16:25, shveta malik wrote:
> > >
> > > Few more comments on 002:
> > >
> > > 5)
> > > +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
> > > {
> >
I further tested inherited tables flow as well wrt ONLY and EXCEPT, it
works well. But while reading docs for the saem, I have few concerns.
1)
While explaining ONLY for EXCEPT, create-publication doc says this
+ This does not apply to a partitioned table, however. The partitions of
+
Shlok, I was trying to validate the interaction of
'publish_via_partition_root' with 'EXCEPT". Found some unexpected
behaviour, can you please review:
Pub:
-
CREATE TABLE tab_root (range_col int,i int,j int) PARTITION BY RANGE
(range_col);
CREATE TABLE tab_part_1 PARTITION OF tab_root FOR
On Sat, Jul 19, 2025 at 4:17 PM Shlok Kyal wrote:
>
> On Mon, 30 Jun 2025 at 16:25, shveta malik wrote:
> >
> > Few more comments on 002:
> >
> > 5)
> > +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
> > {
> >
> > + List*exceptlist;
> > +
> > + exceptlist = GetPublicationRelat
Hi Shlok,
Some review comments for patch v17-0003. I also checked the TAP test this time.
==
doc/src/sgml/logical-replication.sgml
1.
+ publish_generated_columns. Specifying generated
+ columns in a column list using the EXCEPT clause excludes
+ the specified generated columns from bei
On Mon, 21 Jul 2025 at 16:22, shveta malik wrote:
>
> On Sat, Jul 19, 2025 at 4:17 PM Shlok Kyal wrote:
> >
> > On Mon, 30 Jun 2025 at 16:25, shveta malik wrote:
> > >
> > > Few more comments on 002:
> > >
> > > 5)
> > > +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
> > > {
> >
On Sat, Jul 19, 2025 at 4:17 PM Shlok Kyal wrote:
>
> On Mon, 30 Jun 2025 at 16:25, shveta malik wrote:
> >
> > Few more comments on 002:
> >
> > 5)
> > +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
> > {
> >
> > + List*exceptlist;
> > +
> > + exceptlist = GetPublicationRelat
Hi Shlok.
Some review comments for patch v16-0003.
==
Commit message
1.
The column "prexcept" of system catalog "pg_publication_rel" is set to
"true" when publication is created with EXCEPT table or EXCEPT column
list. If column "prattrs" of system catalog "pg_publication_rel" is also
set or
On Mon, 30 Jun 2025 at 16:25, shveta malik wrote:
>
> Few more comments on 002:
>
> 5)
> +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
> {
>
> + List*exceptlist;
> +
> + exceptlist = GetPublicationRelations(pubid, PUBLICATION_PART_ALL);
>
>
> a) Here, we are assuming that the
On Mon, 30 Jun 2025 at 11:54, Peter Smith wrote:
>
> Hi Shlok,
>
> One more thing, I noticed there is no tab-completion code yet for this
> new EXCEPT (column_list) syntax.
>
I have added the tab-completion code in the latest v16 patch [1].
[1]:
https://www.postgresql.org/message-id/CANhcyEW2LK4
On Mon, 30 Jun 2025 at 12:28, shveta malik wrote:
>
> On Fri, Jun 27, 2025 at 3:44 PM Shlok Kyal wrote:
> >
> > On Thu, 26 Jun 2025 at 15:27, shveta malik wrote:
> > >
> > > On Tue, Jun 24, 2025 at 9:48 AM Shlok Kyal
> > > wrote:
> > > >
> > > > I have included the changes for
> > > > it in v
Few more comments on 002:
5)
+GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot)
{
+ List*exceptlist;
+
+ exceptlist = GetPublicationRelations(pubid, PUBLICATION_PART_ALL);
a) Here, we are assuming that the list provided by
GetPublicationRelations() will be except-tables list onl
On Fri, Jun 27, 2025 at 3:44 PM Shlok Kyal wrote:
>
> On Thu, 26 Jun 2025 at 15:27, shveta malik wrote:
> >
> > On Tue, Jun 24, 2025 at 9:48 AM Shlok Kyal wrote:
> > >
> > > I have included the changes for
> > > it in v14-0003 patch.
> > >
> > Thanks for the patches. I have reviewed patch001 al
Hi Shlok,
One more thing, I noticed there is no tab-completion code yet for this
new EXCEPT (column_list) syntax.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Hi Shlok.
Some review comments for v15-0003.
==
doc/src/sgml/catalogs.sgml
1.
- True if the relation must be excluded
+ True if the column list or relation must be excluded from publication.
+ If a column list is specified in prattrs, then
+ exclude only those
On Thu, 26 Jun 2025 at 15:27, shveta malik wrote:
>
> On Tue, Jun 24, 2025 at 9:48 AM Shlok Kyal wrote:
> >
> > I have included the changes for
> > it in v14-0003 patch.
> >
> Thanks for the patches. I have reviewed patch001 alone, please find
> few comments:
>
> 1)
> +
> + The RESET clause
On Tue, Jun 24, 2025 at 9:48 AM Shlok Kyal wrote:
>
> I have included the changes for
> it in v14-0003 patch.
>
Thanks for the patches. I have reviewed patch001 alone, please find
few comments:
1)
+
+ The RESET clause will reset the publication to the
+ default state which includes resetti
Hi Shlok.
Below are some review comments for v14-0003
==
1. GENERAL
Since the new syntax uses EXCEPT, then, in my opinion, you should try
to use that same term where possible when describing things. I
understand it is hard to do this in text and I agree often it makes
more sense to say "excl
> > > 5.
> > > +
> > > + Alter publication mypublication to add table
> > > + users except column
> > > + security_pin:
> > > +
> > > +ALTER PUBLICATION production_publication ADD TABLE users EXCEPT
> > > (security_pin);
> > >
> > > Those tags don't seem correct. e.g. "users" and "security
On Thu, Jun 19, 2025 at 4:42 PM Shlok Kyal wrote:
...
> > 3.
> > TBH, I was wondering why a new catalog attribute was necessary...
> >
> > Can't you simply re-use the existing attribute "prattrs" attribute.
> > e.g. let's just define negative means exclude.
> >
> > e.g. a value of 1 3 means only t
On Tue, Jun 17, 2025 at 5:41 PM Shlok Kyal wrote:
...
> I have attached a patch support excluding columns for publication.
>
> I have added a syntax: "FOR TABLE table_name EXCEPT (c1, c2, ..)"
> It can be used with CREATE or ALTER PUBLICATION.
>
> v12-0003 patch contains the changes for the same.
On Thu, 17 Apr 2025 at 09:12, Amit Kapila wrote:
>
> On Wed, Apr 16, 2025 at 8:22 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Thu, Apr 10, 2025 at 7:25 PM Amit Kapila wrote:
> > >
> > > On Tue, Jan 9, 2024 at 12:02 PM vignesh C wrote:
> > > >
> > > > As I did not see much interest from others, I
On Wed, Apr 16, 2025 at 8:22 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Thu, Apr 10, 2025 at 7:25 PM Amit Kapila wrote:
> >
> > On Tue, Jan 9, 2024 at 12:02 PM vignesh C wrote:
> > >
> > > As I did not see much interest from others, I'm withdrawing this patch
> > > for now. But if there is any interes
On Thu, Apr 10, 2025 at 7:25 PM Amit Kapila wrote:
>
> On Tue, Jan 9, 2024 at 12:02 PM vignesh C wrote:
> >
> > As I did not see much interest from others, I'm withdrawing this patch
> > for now. But if there is any interest others in future, I would be
> > more than happy to work on this feature
On Tue, Jan 9, 2024 at 12:02 PM vignesh C wrote:
>
> As I did not see much interest from others, I'm withdrawing this patch
> for now. But if there is any interest others in future, I would be
> more than happy to work on this feature.
>
Just FYI, I noticed a use case for this patch in email [1].
On Fri, 20 Jan 2023 at 15:30, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
> >
> > On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick
> > wrote:
> > >
> > > 2022年11月7日(月) 22:39 vignesh C :
> > > >
> > > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > > wrote:
On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
> >
> > 2022年11月7日(月) 22:39 vignesh C :
> > >
> > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > wrote:
> > > >
> > > > Hi
> > > >
> > > > cfbot reports the patch no longer ap
On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
>
> 2022年11月7日(月) 22:39 vignesh C :
> >
> > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> > >
> > > Hi
> > >
> > > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> > > currently underway, this would be
2022年11月7日(月) 22:39 vignesh C :
>
> On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> >
> > Hi
> >
> > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> > currently underway, this would be an excellent time to update the patch.
> >
> > [1] http://cfbot.cputube.org/
On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
>
> Hi
>
> cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> currently underway, this would be an excellent time to update the patch.
>
> [1] http://cfbot.cputube.org/patch_40_3646.log
Here is an updated patch which
2022年8月19日(金) 2:41 vignesh C :
>
> On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
> >
> > On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> > >
> > > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > > >
> > > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > > wrote:
> >
On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
>
> On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> >
> > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > >
> > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
> > > > On Monday, May 23, 2022 2:13 PM vigne
On Thu, Aug 18, 2022 at 12:33 PM Nitin Jadhav
wrote:
>
> I spent some time on understanding the proposal and the patch. Here
> are a few comments wrt the test cases.
>
> > +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> > +
> > +-- Verify that tables associated with the publication are
I spent some time on understanding the proposal and the patch. Here
are a few comments wrt the test cases.
> +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> +
> +-- Verify that tables associated with the publication are dropped after RESET
> +\dRp+ testpub_reset
> +ALTER PUBLICATION te
On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
>
> On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> >
> > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > > > Attached v7 patch which fixes the buildfarm wa
On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
>
> On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > > Attached v7 patch which fixes the buildfarm warning for an unused warning
> > > in
> > > release mode as in [1
On Tue, Jun 14, 2022 at 9:10 AM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, June 8, 2022 7:04 PM Amit Kapila
> wrote:
> >
> > On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached v8 patch has the changes for the
> > same.
> > >
> >
> > AFAICS, th
On Wednesday, June 8, 2022 7:04 PM Amit Kapila wrote:
>
> On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v8 patch has the changes for the
> same.
> >
>
> AFAICS, the summary of this proposal is that we want to support
> exclude of certain objects f
On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
>
> Thanks for the comments, the attached v8 patch has the changes for the same.
>
AFAICS, the summary of this proposal is that we want to support
exclude of certain objects from publication with two kinds of
variants. The first variant is to add su
On Tue, May 31, 2022 at 11:51 AM Peter Smith wrote:
>
> Here are my review comments for patch v7-0002.
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
> @@ -1167,8 +1167,9 @@ CONTEXT: processing remote data for replication
> origin "pg_16395" during "INSER
>
> To add tables to a
'On Mon, May 30, 2022 at 1:51 PM Peter Smith wrote:
>
> Here are some minor review comments for v7-0001.
>
> ==
>
> 1. General
>
> Probably the commit message and all the PG docs and code comments
> should be changed to refer to "publication parameters" instead of
> (currently) "publication op
On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > Attached v7 patch which fixes the buildfarm warning for an unused warning in
> > release mode as in [1].
> Hi, thank you for the patches.
>
>
> I'll share several review co
Here are my review comments for patch v7-0002.
==
1. doc/src/sgml/logical-replication.sgml
@@ -1167,8 +1167,9 @@ CONTEXT: processing remote data for replication
origin "pg_16395" during "INSER
To add tables to a publication, the user must have ownership rights on the
table. To a
Here are some minor review comments for v7-0001.
==
1. General
Probably the commit message and all the PG docs and code comments
should be changed to refer to "publication parameters" instead of
(currently) "publication options". This is because these things are
really called "publication_pa
On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> Attached v7 patch which fixes the buildfarm warning for an unused warning in
> release mode as in [1].
Hi, thank you for the patches.
I'll share several review comments.
For v7-0001.
(1) I'll suggest some minor rewording.
+
+ The RESET c
On Sat, May 21, 2022 at 11:06 AM vignesh C wrote:
>
> On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
> >
> > Below are my review comments for v6-0002.
> >
> > ==
> >
> > 1. Commit message.
> > The psql \d family of commands to display excluded tables.
> >
> > SUGGESTION
> > The psql \d f
On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
>
> Below are my review comments for v6-0002.
>
> ==
>
> 1. Commit message.
> The psql \d family of commands to display excluded tables.
>
> SUGGESTION
> The psql \d family of commands can now display excluded tables.
Modified
> ~~~
>
> 2.
On Fri, May 20, 2022 at 5:49 AM Peter Smith wrote:
>
> FYI, although the v6-0002 patch applied cleanly, I found that the SGML
> was malformed and so the pg docs build fails.
>
> ~~~
> e.g.
>
> [postgres@CentOS7-x64 sgml]$ make STYLE=website html
> { \
> echo ""; \
> echo ""; \
> } > version.sg
On Thu, May 19, 2022 at 1:49 PM Peter Smith wrote:
>
> Below are my review comments for v6-0001.
>
> ==
>
> 1. General.
>
> The patch failed 'publication' tests in the make check phase.
>
> Please add this work to the commit-fest so that the 'cfbot' can report
> such errors sooner.
Added comm
Below are my review comments for v6-0002.
==
1. Commit message.
The psql \d family of commands to display excluded tables.
SUGGESTION
The psql \d family of commands can now display excluded tables.
~~~
2. doc/src/sgml/ref/alter_publication.sgml
@@ -22,6 +22,7 @@ PostgreSQL documentation
On Fri, May 20, 2022 at 10:19 AM Peter Smith wrote:
>
> FYI, although the v6-0002 patch applied cleanly, I found that the SGML
> was malformed and so the pg docs build fails.
>
> ~~~
> e.g.
>
> [postgres@CentOS7-x64 sgml]$ make STYLE=website html
> { \
> echo ""; \
> echo ""; \
> } > version.s
FYI, although the v6-0002 patch applied cleanly, I found that the SGML
was malformed and so the pg docs build fails.
~~~
e.g.
[postgres@CentOS7-x64 sgml]$ make STYLE=website html
{ \
echo ""; \
echo ""; \
} > version.sgml
'/usr/bin/perl' ./mk_feature_tables.pl YES
../../../src/backend/catalog
Below are my review comments for v6-0001.
==
1. General.
The patch failed 'publication' tests in the make check phase.
Please add this work to the commit-fest so that the 'cfbot' can report
such errors sooner.
~~~
2. src/backend/commands/publicationcmds.c - AlterPublicationReset
+/*
+ *
On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
>
> Below are my review comments for v5-0002.
>
> There may be an overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. General
>
> Is it really necessary t
On Thursday, May 19, 2022 2:45 AM vignesh C wrote:
> On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
> wrote:
> > (3) src/test/regress/expected/publication.out
> >
> > +-- Verify that only superuser can reset a publication ALTER
> > +PUBLICATION testpub_reset OWNER TO regress_publicat
On Mon, May 16, 2022 at 2:00 PM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new syntax, the
> > changes for
On Wed, May 18, 2022 at 8:30 AM shiy.f...@fujitsu.com
wrote:
>
> On Sat, May 14, 2022 9:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v5 patch has the changes for the
> > same. Also I have made the changes for SKIP Table based on the new
> > syntax, the changes for the same
On Mon, May 16, 2022 at 2:53 PM Peter Smith wrote:
>
> Below are my review comments for v5-0001.
>
> There is some overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. Commit message
>
> This patch adds a n
On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new syntax, the
> > changes for
On Sat, May 14, 2022 9:33 PM vignesh C wrote:
>
> Thanks for the comments, the attached v5 patch has the changes for the
> same. Also I have made the changes for SKIP Table based on the new
> syntax, the changes for the same are available in
> v5-0002-Skip-publishing-the-tables-specified-in-EXCEP
On Tue, May 17, 2022 at 1:56 PM Amit Kapila wrote:
>
> On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
> >
> > Below are my review comments for v5-0002.
> >
> > There may be an overlap with comments recently posted by Osumi-san [1].
> >
> > (I also have review comments for v5-0002; will post t
On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
>
> Below are my review comments for v5-0002.
>
> There may be an overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. General
>
> Is it really necessary t
Below are my review comments for v5-0002.
There may be an overlap with comments recently posted by Osumi-san [1].
(I also have review comments for v5-0002; will post them tomorrow)
==
1. General
Is it really necessary to have to say "EXCEPT TABLE" instead of just
"EXCEPT". It seems unneces
Below are my review comments for v5-0001.
There is some overlap with comments recently posted by Osumi-san [1].
(I also have review comments for v5-0002; will post them tomorrow)
==
1. Commit message
This patch adds a new RESET clause to ALTER PUBLICATION which will reset
the publication t
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
> v5-0002-Skip-publishing-the-tables-specified-in-EX
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
> v5-0002-Skip-publishing-the-tables-specified-in-EX
On Fri, May 13, 2022 at 9:37 AM Peter Smith wrote:
>
> On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
> >
> ...
> > The attached patch has the implementation for "ALTER PUBLICATION
> > pubname RESET". This command will reset the publication to default
> > state which includes resetting the publ
On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
>
...
> The attached patch has the implementation for "ALTER PUBLICATION
> pubname RESET". This command will reset the publication to default
> state which includes resetting the publication options, setting ALL
> TABLES option to false and dropping
On Tue, May 10, 2022 at 9:08 AM vignesh C wrote:
>
> On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
> >
> > On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> > >
> > ...
> > >
> > > Another idea that occurred to me today for tables this is as follows:
> > > 1. Allow to mention except durin
On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
>
> On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> >
> ...
> >
> > Another idea that occurred to me today for tables this is as follows:
> > 1. Allow to mention except during create publication ... For All Tables.
> > CREATE PUBLICATION pub1
On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
>
...
>
> Another idea that occurred to me today for tables this is as follows:
> 1. Allow to mention except during create publication ... For All Tables.
> CREATE PUBLICATION pub1 FOR ALL TABLES EXCEPT TABLE t1,t2;
> 2. Allow to Reset it. This ne
On Thu, May 5, 2022 at 9:20 AM Amit Kapila wrote:
>
> On Wed, May 4, 2022 at 7:05 PM Peter Eisentraut
> wrote:
> >
> > On 14.04.22 15:47, Peter Eisentraut wrote:
> > > That said, I'm not sure this feature is worth the trouble. If this is
> > > useful, what about "whole database except these sche
On Wed, May 4, 2022 at 7:05 PM Peter Eisentraut
wrote:
>
> On 14.04.22 15:47, Peter Eisentraut wrote:
> > That said, I'm not sure this feature is worth the trouble. If this is
> > useful, what about "whole database except these schemas"? What about
> > "create this database from this template ex
On 14.04.22 15:47, Peter Eisentraut wrote:
That said, I'm not sure this feature is worth the trouble. If this is
useful, what about "whole database except these schemas"? What about
"create this database from this template except these schemas". This
could get out of hand. I think we should
On Tue, May 3, 2022 at 2:24 PM Peter Smith wrote:
>
> On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> >
> ...
> > Another idea that occurred to me today for tables this is as follows:
> > 1. Allow to mention except during create publication ... For All Tables.
> > CREATE PUBLICATION pub1 FOR
On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
>
...
> Another idea that occurred to me today for tables this is as follows:
> 1. Allow to mention except during create publication ... For All Tables.
> CREATE PUBLICATION pub1 FOR ALL TABLES EXCEPT TABLE t1,t2;
> 2. Allow to Reset it. This new
On Thu, Apr 28, 2022 at 4:50 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> > Thanks for the comments, the attached v3 patch has the changes for the same.
> Hi
>
> Thank you for updating the patch. Several minor comments on v3.
>
> (1) commit mes
On Fri, Apr 22, 2022 at 9:39 PM Bharath Rupireddy
wrote:
>
> On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
> >
> > This feature adds an option to skip changes of all tables in specified
> > schema while creating publication.
> > This feature is helpful for use cases where the user wants to
>
On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> Thanks for the comments, the attached v3 patch has the changes for the same.
Hi
Thank you for updating the patch. Several minor comments on v3.
(1) commit message
The new syntax allows specifying schemas. For example:
CREATE PUBLICATION pu
On Tue, Apr 26, 2022 at 11:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> > Updated patch by changing the syntax to use EXCEPT instead of SKIP.
> Hi
>
>
> This is my review comments on the v2 patch.
>
> (1) gram.y
>
> I think we can make a uni
On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> Updated patch by changing the syntax to use EXCEPT instead of SKIP.
Hi
This is my review comments on the v2 patch.
(1) gram.y
I think we can make a unified function that merges
preprocess_alltables_pubobj_list with check_except_in_pubobj_
On Sat, Apr 23, 2022 at 2:09 AM Bharath Rupireddy
wrote:
>
> On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
> >
> > Hi,
> >
> > This feature adds an option to skip changes of all tables in specified
> > schema while creating publication.
> > This feature is helpful for use cases where the user
On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except for the changes present in
On Mon, Apr 18, 2022 at 12:32 PM Amit Kapila wrote:
>
> On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
> >
> > On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> >
> > On 12.04.22 08:23, vignesh C wrote:
> > > I have also included the implementation for skipping a few tables from
On Thu, Apr 14, 2022 at 7:18 PM Peter Eisentraut
wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This feature is helpful for use cases w
On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
>
> On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation f
On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This feature is helpful for use cases w
On 12.04.22 08:23, vignesh C wrote:
I have also included the implementation for skipping a few tables from
all tables publication, the 0002 patch has the implementation for the
same.
This feature is helpful for use cases where the user wants to
subscribe to all the changes except for the changes
On Tue, Apr 12, 2022 at 2:23 PM vignesh C wrote:
> The patch does not apply on top of HEAD because of the recent commit,
> attached patch is rebased on top of HEAD.
Thanks for your patches.
Here are some comments for v1-0001:
1.
I found the patch add the following two new functions in gram.y:
pre
On Tue, Apr 12, 2022 2:23 PM vignesh C wrote:
>
> The patch does not apply on top of HEAD because of the recent commit,
> attached patch is rebased on top of HEAD.
>
Thanks for your patch. Here are some comments for 0001 patch.
1. doc/src/sgml/catalogs.sgml
@@ -6438,6 +6438,15 @@ SCRAM-SHA-256
On Wed, Apr 13, 2022 at 2:40 PM Amit Kapila wrote:
>
> On Wed, Apr 13, 2022 at 8:45 AM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
> > >
> > > I understand that part but what I pointed out was that it might be
> > > better to avoid using ADD keyword in this syntax
On Wed, Apr 13, 2022 at 8:45 AM vignesh C wrote:
>
> On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
> >
> > I understand that part but what I pointed out was that it might be
> > better to avoid using ADD keyword in this syntax like: ALTER
> > PUBLICATION pub1 SKIP TABLE t1,t2;
>
> Currently
On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila
> > wrote:
> > >
> > >
> > > For the second syntax (Alter Publication ...), isn't it better to
> > > avoid using ADD? It looks odd to me b
On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
>
> On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
> >
> >
> > For the second syntax (Alter Publication ...), isn't it better to
> > avoid using ADD? It looks odd to me because we are not adding anything
> > in publication with this sytax.
>
>
On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
> >
> > On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> > >
> > > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > > >
> > > > Hi,
> > > >
> > > > This feature adds an option to ski
On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
>
> On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> >
> > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > This feature adds an option to skip changes of all tables in specified
> > > schema while creating publicat
On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except for the changes present in
100 matches
Mail list logo
