Re: Simplifications for error messages related to compression

2022-12-21 Thread Michael Paquier
On Tue, Dec 20, 2022 at 11:12:22PM -0600, Justin Pryzby wrote: > Yes, and its current users (basebackup) output a gzip file, right ? > > pg_dump -Fc doesn't output a gzip file, but now it's using user-facing > compression specifications referring to it as "gzip". Not all of them are compressed ei

Re: Simplifications for error messages related to compression

2022-12-20 Thread Justin Pryzby
On Wed, Dec 21, 2022 at 01:52:21PM +0900, Michael Paquier wrote: > On Tue, Dec 20, 2022 at 08:29:32PM -0600, Justin Pryzby wrote: > > - pg_fatal("not built with zlib support"); > > + pg_fatal("this build does not support compression > > with %s", "gzip")

Re: Simplifications for error messages related to compression

2022-12-20 Thread Michael Paquier
On Tue, Dec 20, 2022 at 08:29:32PM -0600, Justin Pryzby wrote: > - pg_fatal("not built with zlib support"); > + pg_fatal("this build does not support compression > with %s", "gzip"); > > I tried to say in the other thread that gzip != zlib. > > This mes

Re: Simplifications for error messages related to compression

2022-12-20 Thread Justin Pryzby
On Wed, Dec 21, 2022 at 10:43:19AM +0900, Michael Paquier wrote: > On Mon, Dec 19, 2022 at 02:42:13PM +0900, Michael Paquier wrote: > > Thoughts or objections? > > Hearing nothing, done.. - pg_fatal("not built with zlib support"); + pg_fatal("this build

Re: Simplifications for error messages related to compression

2022-12-20 Thread Michael Paquier
On Mon, Dec 19, 2022 at 02:42:13PM +0900, Michael Paquier wrote: > Thoughts or objections? Hearing nothing, done.. -- Michael signature.asc Description: PGP signature