On Wed, Sep 18, 2024 at 08:40:02AM +, Li, Yong wrote:
> I am so glad to see that my patch got committed. Thank you a lot for it!
> This is my first accepted patch. It really means a lot to me.
No problem. Thanks for the patch!
--
Michael
signature.asc
Description: PGP signature
> On Sep 12, 2024, at 13:39, Michael Paquier wrote:
>
> External Email
>
>
> I was looking at all that, and this is only moving code around. While
> the part for heap_xlog_logical_rewrite in rewriteheap.c is a bit sad
> but historical, the header cleanup in heapam.c is nice.
>
> Seeing heap
On Thu, Sep 12, 2024 at 08:12:30AM +0900, Michael Paquier wrote:
> It looks like my mind was wondering away when I wrote this part.
> Sorry for the useless noise.
I was looking at all that, and this is only moving code around. While
the part for heap_xlog_logical_rewrite in rewriteheap.c is a bit
On Wed, Sep 11, 2024 at 04:41:49PM +0900, Michael Paquier wrote:
> +#include "access/heapam_xlog.h"
>
> This is included in heapam.h, but missing from the patch. I guess
> that you fat-fingered a `git add`.
It looks like my mind was wondering away when I wrote this part.
Sorry for the useless no
On Tue, Jul 30, 2024 at 06:48:26AM +, Li, Yong wrote:
> Thank you Kou for your review. I will move the CF to the next
> phase and see what happens.
Quite a fan of what you are proposing here, knowing that heapam.c is
still 8.8k lines of code even after moving the 1.3k lines dedicated to
WAL re
> I think that this proposal is reasonable but we need to get
> attention from a committer to move forward this proposal.
>
>
> Thanks,
> —
> kou
Thank you Kou for your review. I will move the CF to the next
phase and see what happens.
Regards,
Yong
Hi,
In <599e67d2-2929-4858-b8bc-f9c4ae889...@ebay.com>
"Re: Separate HEAP WAL replay logic into its own file" on Fri, 26 Jul 2024
07:56:12 +,
"Li, Yong" wrote:
>> 1. Could you create your patch by "git format-patch -vN master"
>> or so
> On Jul 23, 2024, at 09:54, Sutou Kouhei wrote:
>
>
> Here are my comments for your patch:
>
> 1. Could you create your patch by "git format-patch -vN master"
> or something? If you create your patch by "git format-patch",
> we can apply your patch by "git am XXX.patch".
>
Thanks for your
Hi,
I'm reviewing patches in commitfest 2024-07:
https://commitfest.postgresql.org/48/
This is the 5th patch:
https://commitfest.postgresql.org/48/5054/
FYI: https://commitfest.postgresql.org/48/4681/ is my patch.
In
"Re: Separate HEAP WAL replay logic into its own file" on T
> On Jun 18, 2024, at 20:42, Melanie Plageman wrote:
>
> External Email
>
> On Mon, Jun 17, 2024 at 9:12 PM Li, Yong wrote:
>>
>> As a newcomer, when I was walking through the code looking for WAL replay
>> related code, it was relatively easy for me to find them for the B-Tree
>> access m
On Mon, Jun 17, 2024 at 9:12 PM Li, Yong wrote:
>
> As a newcomer, when I was walking through the code looking for WAL replay
> related code, it was relatively easy for me to find them for the B-Tree
> access method because of the “xlog” hint in the file names. It took me a
> while to find the
> On Jun 17, 2024, at 23:01, Melanie Plageman wrote:
>
> External Email
>
> On Mon, Jun 17, 2024 at 2:20 AM Li, Yong wrote:
>>
>> Hi PostgreSQL hackers,
>>
>> For most access methods in PostgreSQL, the implementation of the access
>> method itself and the implementation of its WAL replay l
On Mon, Jun 17, 2024 at 2:20 AM Li, Yong wrote:
>
> Hi PostgreSQL hackers,
>
> For most access methods in PostgreSQL, the implementation of the access
> method itself and the implementation of its WAL replay logic are organized in
> separate source files. However, the HEAP access method is an e
13 matches
Mail list logo
