Re: SSL test names

2018-02-08 Thread Peter Eisentraut
On 2/7/18 23:18, Michael Paquier wrote: > You need to update the comment on top of test_connect_ok in > ServerSetup.pm. done and committed > Wouldn't it be better to use the expected result > as an argument and merge test_connect_ok and test_connect_fails? That doesn't seem to be the general sty

Re: SSL test names

2018-02-08 Thread Daniel Gustafsson
> On 07 Feb 2018, at 17:54, Peter Eisentraut > wrote: > I have found the old way very confusing while working with several > SSL-related patches recently. Agreed. I had similar, but way uglier, hacks in my Secure Transport branch. +1 on something like this. cheers ./daniel

Re: SSL test names

2018-02-07 Thread Michael Paquier
On Wed, Feb 07, 2018 at 11:54:52AM -0500, Peter Eisentraut wrote: > Here is a patch that gives the tests in the SSL test suite proper names > instead of just writing out the connection strings. So instead of > > # running client tests > # test that the server doesn't accept non-SSL connections >