Re: SQL/JSON json_table plan clause

2025-03-15 Thread Nikita Malakhov
Hi Amit! Thank you for your feedback, I'll check it out in a couple of days and reply. -- Regards, Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/

Re: SQL/JSON json_table plan clause

2025-03-14 Thread Amit Langote
Hi Nikita, I was looking at the patch you posted on Feb 3. Two high-level comments: * The documentation additions are missing. * It looks like the patch mixes refactoring changes with new functionality, which makes it harder to follow what's existing vs. new. Could you separate these changes so

Re: SQL/JSON json_table plan clause

2025-02-04 Thread Nikita Malakhov
Hi Amit! No, JSON_TABLE is ok. I've meant that in the previous approach to PLAN clause implementation there were some wrong tests. On Tue, Feb 4, 2025 at 6:05 AM Amit Langote wrote: > Hi Nikita, > > On Wed, Dec 18, 2024 at 12:11 AM Nikita Malakhov > wrote: > > > > Hi hackers! > > > > This thre

Re: SQL/JSON json_table plan clause

2025-02-03 Thread Amit Langote
Hi Nikita, On Wed, Dec 18, 2024 at 12:11 AM Nikita Malakhov wrote: > > Hi hackers! > > This thread is further work continued in [1], where Amit Langote > suggested starting discussion on the remaining SQL/JSON feature > 'PLAN clause for JSON_TABLE' anew. > > We'd like to help with merging SQL/JSO

Re: SQL/JSON json_table plan clause

2025-02-02 Thread Vladlen Popolitov
Nikita Malakhov писал(а) 2025-02-03 02:43: Hi hackers! Patch has been rebased onto the current master. -- Regards, Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/ Hi! Tested on Mac with 'make check', all tests passed OK. -- Best regards, Vladlen P

Re: SQL/JSON json_table plan clause

2025-01-16 Thread Vladlen Popolitov
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: not tested Documentation:not tested Hi! Proposed patch tested at Macosx, compiled and build without warni

Re: SQL/JSON json_table plan clause

2024-12-17 Thread Andrew Dunstan
On 2024-12-17 Tu 10:11 AM, Nikita Malakhov wrote: Hi hackers! This thread is further work continued in [1], where Amit Langote suggested starting discussion on the remaining SQL/JSON feature 'PLAN clause for JSON_TABLE' anew. We'd like to help with merging SQL/JSON patches into vanilla, and h