Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-04-08 Thread Michael Paquier
On Tue, Apr 03, 2018 at 03:04:10PM +0900, Michael Paquier wrote: > At the end, it seems to me that what I am proposing is themost readable > approach, and with proper documentation things should be handled > finely... Or there is an approach you have in mind I do not foresee? With feature freeze

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-04-02 Thread Michael Paquier
On Mon, Apr 02, 2018 at 10:35:09AM -0400, Peter Eisentraut wrote: > I took a quick look at that part. It appears to be quite invasive, more > than I would have hoped. Basically, it imposes that from now on all > program invocations must observe the bindir setting, which someone is > surely going

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-04-02 Thread Peter Eisentraut
On 3/21/18 21:49, Michael Paquier wrote: > On Thu, Mar 22, 2018 at 09:42:35AM +0800, Craig Ringer wrote: >> I'm super excited by the idea of multi-version support in TAP, if that's >> what you mean. >> >> Why? Because I use TAP heavily in extensions. Especially replication >> extensions. Which like

Re: Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-21 Thread Michael Paquier
On Thu, Mar 22, 2018 at 09:42:35AM +0800, Craig Ringer wrote: > I'm super excited by the idea of multi-version support in TAP, if that's > what you mean. > > Why? Because I use TAP heavily in extensions. Especially replication > extensions. Which like to talk across multiple versions. I currently

Re: Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-21 Thread Craig Ringer
On 22 March 2018 at 09:39, Michael Paquier wrote: > On Wed, Mar 21, 2018 at 10:51:04AM -0400, David Steele wrote: > > On 3/6/18 4:12 PM, Tom Lane wrote: > > It seems the consensus is that we'll need a build farm update before we > > can move forward with the patch and that we don't need to wait l

Re: Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-21 Thread Michael Paquier
On Wed, Mar 21, 2018 at 10:51:04AM -0400, David Steele wrote: > On 3/6/18 4:12 PM, Tom Lane wrote: > It seems the consensus is that we'll need a build farm update before we > can move forward with the patch and that we don't need to wait long for > people to upgrade. > > Andrew, do you have a date

Re: Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-21 Thread David Steele
On 3/6/18 4:12 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 3/4/18 16:09, Andrew Dunstan wrote: >>> If you want to do this soon I can put out a Buildfarm Client release >>> fairly quickly. > >> I think the dependency is mostly the other way around. How quickly >> would build farm owners

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-06 Thread Tom Lane
Peter Eisentraut writes: > On 3/4/18 16:09, Andrew Dunstan wrote: >> If you want to do this soon I can put out a Buildfarm Client release >> fairly quickly. > I think the dependency is mostly the other way around. How quickly > would build farm owners install the upgrade? IIUC, the buildfarm sc

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-06 Thread Peter Eisentraut
On 3/4/18 16:09, Andrew Dunstan wrote: >>> AFAICT, this still has the same problem as the previous take, namely >>> that adding a TAP test suite to the pg_upgrade subdirectory will end up >>> with the build farm client running the pg_upgrade tests twice. What we >>> likely need here is an update t

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-04 Thread Andrew Dunstan
On Sun, Mar 4, 2018 at 2:34 PM, Andrew Dunstan wrote: > On Sun, Mar 4, 2018 at 12:42 AM, Peter Eisentraut > wrote: >> On 1/26/18 03:00, Michael Paquier wrote: >>> As promised on a recent thread, here is a second tentative to switch >>> pg_upgrade's test.sh into a TAP infrastructure. >> >> AFAICT,

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-03 Thread Andrew Dunstan
On Sun, Mar 4, 2018 at 12:42 AM, Peter Eisentraut wrote: > On 1/26/18 03:00, Michael Paquier wrote: >> As promised on a recent thread, here is a second tentative to switch >> pg_upgrade's test.sh into a TAP infrastructure. > > AFAICT, this still has the same problem as the previous take, namely >

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-03 Thread Peter Eisentraut
On 1/26/18 03:00, Michael Paquier wrote: > As promised on a recent thread, here is a second tentative to switch > pg_upgrade's test.sh into a TAP infrastructure. AFAICT, this still has the same problem as the previous take, namely that adding a TAP test suite to the pg_upgrade subdirectory will en

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-02 Thread Alvaro Herrera
Andrew Dunstan wrote: > One of the significant pluses to TestUpgradeXversion.pm is that it > tests upgrading quite a bit more than the standard regression > database. It also tests all the contrib databases and the isolation > and pl_regression databases. I think we should definitely be including

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-02 Thread Michael Paquier
On Fri, Mar 02, 2018 at 06:33:55PM +1030, Andrew Dunstan wrote: > TestUpgradeXversion.pm is different in a number of respects from the > inbuilt test regime. It doesn't run the normal regression suite to set > up a test. Rather, it saves out the installed binaries and data > directory of the buildf

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-02 Thread Michael Paquier
On Thu, Mar 01, 2018 at 10:08:06PM -0800, Andres Freund wrote: > On 2018-01-26 17:00:26 +0900, Michael Paquier wrote: >> +elsif (defined($ENV{oldsrc}) && >> +defined($ENV{oldbindir}) && >> +defined($ENV{oldlibdir})) >> +{ >> +# A run is wanted on an old version as base. >> +$oldsrc

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-02 Thread Andrew Dunstan
On Fri, Mar 2, 2018 at 4:38 PM, Andres Freund wrote: > Hi, > > On 2018-01-26 17:00:26 +0900, Michael Paquier wrote: >> Another topic that I would like to discuss is how this interface is fit >> for the buildfarm code. After hacking my stuff, I have looked at the >> buildfarm code to notice that t

Re: Rewriting the test of pg_upgrade as a TAP test - take two

2018-03-01 Thread Andres Freund
Hi, On 2018-01-26 17:00:26 +0900, Michael Paquier wrote: > Another topic that I would like to discuss is how this interface is fit > for the buildfarm code. After hacking my stuff, I have looked at the > buildfarm code to notice that things like TestUpgradeXversion.pm do > *not* make use of test.