Re: Residual cpluspluscheck issues

2020-09-30 Thread Tom Lane
Jesse Zhang writes: > So it's been 17 months since you sent this email, so I'm not sure that > nothing has happened (off list or in the code base), but... Well, we fixed the case that was discussed at the time [1]. I'm not exactly convinced about removing the register keywords in s_lock.h. Thos

Re: Residual cpluspluscheck issues

2020-09-30 Thread Jesse Zhang
Hi Tom, So it's been 17 months since you sent this email, so I'm not sure that nothing has happened (off list or in the code base), but... On Sun, Jun 2, 2019 at 9:53 AM Tom Lane wrote: > * On FreeBSD 12, I get > > /home/tgl/pgsql/src/include/utils/hashutils.h:23:23: warning: 'register' > storag