>
> Committed.
>
> I made two notable changes: I renamed the function, since it looked
> like EmitWarningsOnPlaceholders() but was doing something not analogous.
Also, you had in your function
>
> strncmp(varName, var->name, varLen)
>
> probably copied from EmitWarningsOnPlaceholders(), bu
On 07.10.21 14:03, Florin Irion wrote:
I adjusted a bit the code and configured my mail client to
send patch attachments appropiately(hopefully). :)
So here is my second version.
Committed.
I made two notable changes: I renamed the function, since it looked
like EmitWarningsOnPlaceholders()
Hi,
Il giorno gio 21 ott 2021 alle ore 08:02 Michael Paquier <
mich...@paquier.xyz> ha scritto:
>
> On Thu, Sep 30, 2021 at 11:54:04PM +0200, Florin Irion wrote:
> > We could also help users get a warning if they set a parameter with the
> > `SET`
> > command. I've seen many cases where users make
On Thu, Sep 30, 2021 at 11:54:04PM +0200, Florin Irion wrote:
> We could also help users get a warning if they set a parameter with the
> `SET`
> command. I've seen many cases where users make typos and break things badly,
> check the following example:
>
> ```
> postgres=# BEGIN;
> BEGIN
> postgr
Hi,
I adjusted a bit the code and configured my mail client to
send patch attachments appropiately(hopefully). :)
So here is my second version.
Cheers,
Florin IrionFrom 9a50261faad3a7578dab150f1c05b510285e283c Mon Sep 17 00:00:00 2001
From: Florin Irion
Date: Thu, 7 Oct 2021 09:51:29 +0200
Il giorno ven 1 ott 2021 alle ore 00:26 Chapman Flack
ha scritto:
>
> On 09/30/21 17:54, Florin Irion wrote:
>
> > We could also help users get a warning if they set a parameter with the
> > `SET` command.
>
> This is funny. For years I have been so confident I knew how this worked
> that I, obvio
On Thu, 2021-09-30 at 18:26 -0400, Chapman Flack wrote:
> On 09/30/21 17:54, Florin Irion wrote:
> > We could also help users get a warning if they set a parameter with the
> > `SET` command.
>
> So I am in favor of patching this.
+1 on the idea.
Yours,
Laurenz Albe
On 09/30/21 17:54, Florin Irion wrote:
> We could also help users get a warning if they set a parameter with the
> `SET` command.
This is funny. For years I have been so confident I knew how this worked
that I, obviously, hadn't tried it. :)
My first setting of a made-up variable gets no warning
