Re: Removing vacuum_cleanup_index_scale_factor

2021-03-10 Thread Masahiko Sawada
On Thu, Mar 11, 2021 at 10:12 AM Peter Geoghegan wrote: > > On Tue, Mar 9, 2021 at 7:42 PM Peter Geoghegan wrote: > > My current plan is to commit everything within the next day or two. > > This includes backpatching to Postgres 13 only. > > Pushed, thanks. Great! Thank you! Regards, -- Masah

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-10 Thread Peter Geoghegan
On Tue, Mar 9, 2021 at 7:42 PM Peter Geoghegan wrote: > My current plan is to commit everything within the next day or two. > This includes backpatching to Postgres 13 only. Pushed, thanks. -- Peter Geoghegan

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-09 Thread Peter Geoghegan
On Mon, Mar 8, 2021 at 10:21 PM Masahiko Sawada wrote: > Thank you for the patches. I looked at 0001 patch and have a comment: > > +* We don't report to the stats collector here because the stats collector > +* only tracks per-table stats. Reset the changes_since_analyze counter > +*

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-08 Thread Masahiko Sawada
On Tue, Mar 9, 2021 at 7:35 AM Peter Geoghegan wrote: > > On Mon, Mar 8, 2021 at 1:38 PM Tom Lane wrote: > > As you say, the history here is a bit convoluted, but it seems like > > a good principle to avoid interconnections between VACUUM and ANALYZE > > as much as we can. I haven't been paying

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-08 Thread Peter Geoghegan
On Mon, Mar 8, 2021 at 1:38 PM Tom Lane wrote: > As you say, the history here is a bit convoluted, but it seems like > a good principle to avoid interconnections between VACUUM and ANALYZE > as much as we can. I haven't been paying enough attention to this > thread to have more insight than that.

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-08 Thread Tom Lane
Peter Geoghegan writes: > I think that a simpler approach would work better: When > ANALYZE/do_analyze_rel() decides whether or not it should call > vac_update_relstats() for each index, it should simply not care > whether or not this is a VACUUM ANALYZE (as opposed to a simple > ANALYZE). This is

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-08 Thread Peter Geoghegan
On Tue, Mar 2, 2021 at 6:01 PM Peter Geoghegan wrote: > 1. Any objections to the idea of teaching VACUUM ANALYZE to > distinguish between the cases where VACUUM ran and performed "real > index vacuuming", to make it more intelligent about overwriting > pg_class stats for indexes? I think that a s

Re: Removing vacuum_cleanup_index_scale_factor

2021-03-02 Thread Peter Geoghegan
On Mon, Mar 1, 2021 at 10:33 PM Masahiko Sawada wrote: > The original design that made VACUUM set > pg_class.reltuples/pg_class.relpages in indexes (from 15+ years ago) > assumed that it was cheap to handle statistics in passing. Even if we > have btvacuumcleanup() not do an index scan at all, thi