On Thu, Jul 27, 2023 at 12:11:38PM -0400, Tom Lane wrote:
> Done that way. Thanks for looking at it!
Thanks for applying!
--
Michael
signature.asc
Description: PGP signature
Michael Paquier writes:
> Seeing what this code does, the odds of needing an err_msg seem rather
> low to me, so I would just remove it for now for the sake of clarity.
> It can always be added later if need be.
Done that way. Thanks for looking at it!
regards, tom lane
On Mon, Jul 24, 2023 at 08:21:54PM -0400, Tom Lane wrote:
> Yeah, I dithered about that. I felt like removing it only to put it
> back later would be silly, but then again maybe there won't ever be
> a need to put it back. I'm OK with removing it if there's not
> objections.
Seeing what this cod
Michael Paquier writes:
> I find the choice to keep err_msg in next_token() a bit confusing in
> next_field_expand(). If no errors are possible, why not just get rid
> of it?
Yeah, I dithered about that. I felt like removing it only to put it
back later would be silly, but then again maybe ther
On Mon, Jul 24, 2023 at 03:58:31PM -0700, Nathan Bossart wrote:
> On Mon, Jul 24, 2023 at 03:07:07PM -0300, Fabrízio de Royes Mello wrote:
>>> Given the infrequency of complaints, I'm inclined to apply
>>> the more thorough fix only in HEAD, and to just raise MAX_TOKEN
>>> in the back branches. Th
On Mon, Jul 24, 2023 at 03:07:07PM -0300, Fabrízio de Royes Mello wrote:
> On Mon, Jul 24, 2023 at 2:53 PM Tom Lane wrote:
>>
>> We got a complaint at [1] about how a not-so-unreasonable LDAP
>> configuration can hit the "authentication file token too long,
>> skipping" error case in hba.c's next_
On Mon, Jul 24, 2023 at 2:53 PM Tom Lane wrote:
>
> We got a complaint at [1] about how a not-so-unreasonable LDAP
> configuration can hit the "authentication file token too long,
> skipping" error case in hba.c's next_token(). I think we've
> seen similar complaints before, although a desultory
