Re: Remove win32ver.rc from version_stamp.pl

2020-03-10 Thread Peter Eisentraut
On 2020-03-09 15:55, Tom Lane wrote: Peter Eisentraut writes: On 2020-03-01 23:51, Tom Lane wrote: In general, while I'm on board with the idea, I wonder whether it wouldn't be smarter to keep on defining PG_MAJORVERSION as a string, and just add PG_MAJORVERSION_NUM alongside of it. Agreed.

Re: Remove win32ver.rc from version_stamp.pl

2020-03-09 Thread Tom Lane
Peter Eisentraut writes: > On 2020-03-01 23:51, Tom Lane wrote: >> In general, while I'm on board with the idea, I wonder whether it >> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string, >> and just add PG_MAJORVERSION_NUM alongside of it. > Agreed. Here is another patch. This

Re: Remove win32ver.rc from version_stamp.pl

2020-03-09 Thread Peter Eisentraut
On 2020-03-01 23:51, Tom Lane wrote: In general, while I'm on board with the idea, I wonder whether it wouldn't be smarter to keep on defining PG_MAJORVERSION as a string, and just add PG_MAJORVERSION_NUM alongside of it. This would eliminate some hunks from the patch in places where it's more c

Re: Remove win32ver.rc from version_stamp.pl

2020-03-01 Thread Tom Lane
Peter Eisentraut writes: > This removes another relic from the old nmake-based Windows build. > version_stamp.pl put version number information into win32ver.rc. But > win32ver.rc already gets other version number information from the > preprocessor at build time, so it would make more sense i