Re: Remove vardata parameters from eqjoinsel_inner

2025-04-05 Thread Tom Lane
Richard Guo writes: > On Fri, Feb 21, 2025 at 7:04 PM Ilia Evdokimov > wrote: >> When calculating selectivity for an inner equijoin, we call >> eqjoinsel_inner, which uses unused parameters vardata1 and vardata2. >> These parameters might have been left behind accidentally when we moved >> gettin

Re: Remove vardata parameters from eqjoinsel_inner

2025-03-27 Thread Richard Guo
On Fri, Feb 21, 2025 at 7:04 PM Ilia Evdokimov wrote: > When calculating selectivity for an inner equijoin, we call > eqjoinsel_inner, which uses unused parameters vardata1 and vardata2. > These parameters might have been left behind accidentally when we moved > getting sslots out of the function.

Re: Remove vardata parameters from eqjoinsel_inner

2025-03-27 Thread Ilia Evdokimov
On 27.03.2025 10:48, Richard Guo wrote: I'm wondering whether we should also remove parameter vardata1 from eqjoinsel_semi. vardata2 is still needed though to clamp nd2 to be not more than the rel's row estimate. Thanks Richard Indeed, the parameter vardata1 in eqjoinsel_semi() is currently