Re: Remove utils/acl.h from catalog/objectaddress.h

2020-03-10 Thread Peter Eisentraut
On 2020-03-09 17:07, Alvaro Herrera wrote: On 2020-Mar-07, Peter Eisentraut wrote: I noticed that catalog/objectaddress.h includes utils/acl.h for no apparent reason. It turns out this used to be needed but not anymore. So removed it and cleaned up the fallout. Patch attached. parser/parse_

Re: Remove utils/acl.h from catalog/objectaddress.h

2020-03-09 Thread Alvaro Herrera
On 2020-Mar-07, Peter Eisentraut wrote: > I noticed that catalog/objectaddress.h includes utils/acl.h for no apparent > reason. It turns out this used to be needed but not anymore. So removed it > and cleaned up the fallout. Patch attached. parser/parse_nodes.h already includes nodes/parsenodes

Re: Remove utils/acl.h from catalog/objectaddress.h

2020-03-08 Thread Tom Lane
Peter Eisentraut writes: > I noticed that catalog/objectaddress.h includes utils/acl.h for no > apparent reason. It turns out this used to be needed but not anymore. > So removed it and cleaned up the fallout. Patch attached. Seems reasonable. One thing I noticed is that if you are including