Re: Remove trailing comma from enums

2022-01-06 Thread Kyotaro Horiguchi
At Thu, 6 Jan 2022 12:52:50 +1100, Peter Smith wrote in > On Thu, Jan 6, 2022 at 12:23 PM Tom Lane wrote: > > > > Thomas Munro writes: > > > On Thu, Jan 6, 2022 at 12:56 PM Peter Smith wrote: > > >> These are quite rare in the PG src, so I doubt they are intentional. > > >> PSA a patch to remo

Re: Remove trailing comma from enums

2022-01-05 Thread Peter Smith
On Thu, Jan 6, 2022 at 12:23 PM Tom Lane wrote: > > Thomas Munro writes: > > On Thu, Jan 6, 2022 at 12:56 PM Peter Smith wrote: > >> These are quite rare in the PG src, so I doubt they are intentional. > >> PSA a patch to remove the trailing commas for all that I found. > > > -1. I don't see th

Re: Remove trailing comma from enums

2022-01-05 Thread Tom Lane
Thomas Munro writes: > On Thu, Jan 6, 2022 at 12:56 PM Peter Smith wrote: >> These are quite rare in the PG src, so I doubt they are intentional. >> PSA a patch to remove the trailing commas for all that I found. > -1. I don't see the problem with C99 trailing commas. They avoid > noisy diff l

Re: Remove trailing comma from enums

2022-01-05 Thread Thomas Munro
On Thu, Jan 6, 2022 at 12:56 PM Peter Smith wrote: > I saw one (and then went looking and found some more) enum with a > trailing comma. > > These are quite rare in the PG src, so I doubt they are intentional. > > PSA a patch to remove the trailing commas for all that I found. -1. I don't see th