Re: Remove obsolete pg_attrdef.adsrc column

2018-11-01 Thread Peter Eisentraut
On 27/10/2018 23:19, Daniel Gustafsson wrote: >> On 27 Oct 2018, at 12:57, Peter Eisentraut >> wrote: >> >> On 23/10/2018 19:48, Daniel Gustafsson wrote: On 23 Oct 2018, at 15:17, Peter Eisentraut wrote: I propose the attached patch to remove the long-unused catalog column >

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-27 Thread Daniel Gustafsson
> On 27 Oct 2018, at 12:57, Peter Eisentraut > wrote: > > On 23/10/2018 19:48, Daniel Gustafsson wrote: >>> On 23 Oct 2018, at 15:17, Peter Eisentraut >>> wrote: >>> >>> I propose the attached patch to remove the long-unused catalog column >>> pg_attrdef.adsrc. >> >> +1, I ran into a bug in

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-27 Thread Peter Eisentraut
On 23/10/2018 19:48, Daniel Gustafsson wrote: >> On 23 Oct 2018, at 15:17, Peter Eisentraut >> wrote: >> >> I propose the attached patch to remove the long-unused catalog column >> pg_attrdef.adsrc. > > +1, I ran into a bug in an app as recently as today where adsrc was used > instead of pg_get_

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-23 Thread Daniel Gustafsson
> On 23 Oct 2018, at 15:17, Peter Eisentraut > wrote: > > I propose the attached patch to remove the long-unused catalog column > pg_attrdef.adsrc. +1, I ran into a bug in an app as recently as today where adsrc was used instead of pg_get_expr(). Patch looks good. I probably would’ve opted fo

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-23 Thread Alvaro Herrera
On 2018-Oct-23, Peter Eisentraut wrote: > I propose the attached patch to remove the long-unused catalog column > pg_attrdef.adsrc. +1, looks good. I think this change has been waiting for a very long time -- documented as useless by 81c41e3d0ed3 (Jan 2005, general doc copy-edit, a paragraph you