Re: Remove an obsolete comment in gistinsert()

2024-11-06 Thread Tender Wang
Michael Paquier 于2024年11月7日周四 14:11写道: > On Thu, Nov 07, 2024 at 10:57:08AM +0800, Tender Wang wrote: > > Thanks for reviewing this. I have added it to the 2015-01 commitfest. > > Right. I don't quite see why this comment would apply anymore, and > the commit you are pointing to looks right. Wi

Re: Remove an obsolete comment in gistinsert()

2024-11-06 Thread Michael Paquier
On Thu, Nov 07, 2024 at 10:57:08AM +0800, Tender Wang wrote: > Thanks for reviewing this. I have added it to the 2015-01 commitfest. Right. I don't quite see why this comment would apply anymore, and the commit you are pointing to looks right. Will fix. -- Michael signature.asc Description: PG

Re: Remove an obsolete comment in gistinsert()

2024-11-06 Thread Tender Wang
Aleksander Alekseev 于2024年11月5日周二 22:08写道: > Hi Tender, > > > While learning the GIST codes, I find an obsolete comment in gistinsert > (). > > > > itup = gistFormTuple(giststate, r, > > values, isnull, true /* size is > currently bogus */ ); > > Thanks for repor

Re: Remove an obsolete comment in gistinsert()

2024-11-05 Thread Aleksander Alekseev
Hi Tender, > While learning the GIST codes, I find an obsolete comment in gistinsert (). > > itup = gistFormTuple(giststate, r, > values, isnull, true /* size is currently > bogus */ ); Thanks for reporting. I agree that this is an oversight of commit 1f7ef54.