Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-27 Thread Andy Fan
Andy Fan writes: > Álvaro Herrera writes: > >> Hmm >> >> So these functions were created from macros in commit 34694ec888d6, >> which themselves had been added for the first time in commit >> 37484ad2aace. However, it appears that they were added only because >> they were mirroring HeapTupleHea

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-26 Thread Andy Fan
Álvaro Herrera writes: > Hmm > > So these functions were created from macros in commit 34694ec888d6, > which themselves had been added for the first time in commit > 37484ad2aace. However, it appears that they were added only because > they were mirroring HeapTupleHeaderSetXminFrozen(), and whil

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-26 Thread Álvaro Herrera
Hmm So these functions were created from macros in commit 34694ec888d6, which themselves had been added for the first time in commit 37484ad2aace. However, it appears that they were added only because they were mirroring HeapTupleHeaderSetXminFrozen(), and while the latter was immediately used, t

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-25 Thread Andy Fan
Nathan Bossart writes: > On Wed, Jun 25, 2025 at 09:28:50AM +, Andy Fan wrote: >> Michael Paquier writes: >>> On Wed, Jun 25, 2025 at 07:47:27AM +, Andy Fan wrote: When I am reading the code, I first thought I can do something in HeapTupleheaderSetXminCommitted, then I realized

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-25 Thread Nathan Bossart
On Wed, Jun 25, 2025 at 09:28:50AM +, Andy Fan wrote: > Michael Paquier writes: >> On Wed, Jun 25, 2025 at 07:47:27AM +, Andy Fan wrote: >>> When I am reading the code, I first thought I can do something in >>> HeapTupleheaderSetXminCommitted, then I realized we have SetHintBits. >>> After

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-25 Thread Andy Fan
Michael Paquier writes: > On Wed, Jun 25, 2025 at 07:47:27AM +, Andy Fan wrote: >> When I am reading the code, I first thought I can do something in >> HeapTupleheaderSetXminCommitted, then I realized we have SetHintBits. >> After some research, I find HeapTupleHeaderSetXminCommitted is never

Re: Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

2025-06-25 Thread Michael Paquier
On Wed, Jun 25, 2025 at 07:47:27AM +, Andy Fan wrote: > When I am reading the code, I first thought I can do something in > HeapTupleheaderSetXminCommitted, then I realized we have SetHintBits. > After some research, I find HeapTupleHeaderSetXminCommitted is never > used and it looks not safe t