Re: Relids instead of Bitmapset * in plannode.h

2023-11-08 Thread Tom Lane
Ashutosh Bapat writes: > On Tue, Nov 7, 2023 at 8:54 PM Tom Lane wrote: >> Yes, I'm pretty sure that's exactly the reason, and I'm strongly >> against the initially-proposed patch. The include footprint of >> pathnodes.h would be greatly expanded, for no real benefit. > As I mentioned in [1] th

Re: Relids instead of Bitmapset * in plannode.h

2023-11-08 Thread Ashutosh Bapat
On Tue, Nov 7, 2023 at 8:54 PM Tom Lane wrote: > > Alvaro Herrera writes: > > On 2023-Oct-31, Ashutosh Bapat wrote: > >> For some reason plannode.h has declared variable to hold RTIs as > >> Bitmapset * instead of Relids like other places. Here's patch to fix > >> it. This is superficial change a

Re: Relids instead of Bitmapset * in plannode.h

2023-11-07 Thread Tom Lane
Alvaro Herrera writes: > On 2023-Oct-31, Ashutosh Bapat wrote: >> For some reason plannode.h has declared variable to hold RTIs as >> Bitmapset * instead of Relids like other places. Here's patch to fix >> it. This is superficial change as Relids is typedefed to Bitmapset *. >> Build succeeds for

Re: Relids instead of Bitmapset * in plannode.h

2023-11-07 Thread Alvaro Herrera
Hello, On 2023-Oct-31, Ashutosh Bapat wrote: > For some reason plannode.h has declared variable to hold RTIs as > Bitmapset * instead of Relids like other places. Here's patch to fix > it. This is superficial change as Relids is typedefed to Bitmapset *. > Build succeeds for me and also make chec