Re: Relcache refactoring

2024-10-31 Thread Tom Lane
Heikki Linnakangas writes: > I was finally able to reproduce this, by running the failing pg_regress > tests concurrently with repeated "vacuum full pg_database" calls. It's > curious that 'prion' failed on the first run after the commit, I was not > able to reproduce it by just running the unm

Re: Relcache refactoring

2024-10-31 Thread Heikki Linnakangas
On 31/10/2024 12:06, Heikki Linnakangas wrote: On 31/10/2024 10:14, Heikki Linnakangas wrote: Committed with those fixes, thanks for the review! There is a failure in the buildfarm animal 'prion', which builds with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options. I'll look into tha

Re: Relcache refactoring

2024-10-31 Thread Heikki Linnakangas
On 31/10/2024 10:14, Heikki Linnakangas wrote: Committed with those fixes, thanks for the review! There is a failure in the buildfarm animal 'prion', which builds with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options. I'll look into that later today. (I did test with -DRELCACHE_FORCE

Re: Relcache refactoring

2024-10-31 Thread Heikki Linnakangas
On 23/09/2024 04:39, jian he wrote: static void RelationClearRelation(Relation relation) { Assert(RelationHasReferenceCountZero(relation)); Assert(!relation->rd_isnailed); /* * Relations created in the same transaction must never be removed, see * RelationFlushRelation

Re: Relcache refactoring

2024-09-22 Thread jian he
On Wed, Jun 5, 2024 at 9:56 PM Heikki Linnakangas wrote: > > ## Patch 3: Split RelationClearRelation into three different functions > > RelationClearRelation() is complicated. Depending on the 'rebuild' > argument and the circumstances, like if it's called in a transaction and > whether the relati