Re: Regression tests vs SERIALIZABLE

2021-03-16 Thread Tom Lane
Thomas Munro writes: > On Tue, Mar 16, 2021 at 3:28 AM Tom Lane wrote: >> Usually, if we issue a SET in the regression tests, we explicitly RESET >> as soon thereafter as practical, so as to have a well-defined scope >> where the script is running under unusual conditions. > Oh, of course. Than

Re: Regression tests vs SERIALIZABLE

2021-03-16 Thread Thomas Munro
On Tue, Mar 16, 2021 at 3:28 AM Tom Lane wrote: > Thomas Munro writes: > > On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro wrote: > >> However, since commit 862ef372d6b, there *is* one test that fails if > >> you run make installcheck against a cluster running with -c > >> default_transaction_isola

Re: Regression tests vs SERIALIZABLE

2021-03-15 Thread Tom Lane
Thomas Munro writes: > On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro wrote: >> However, since commit 862ef372d6b, there *is* one test that fails if >> you run make installcheck against a cluster running with -c >> default_transaction_isolation=serializable: transaction.sql. Is that >> a mistake?

Re: Regression tests vs SERIALIZABLE

2021-03-15 Thread Thomas Munro
On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro wrote: > However, since commit 862ef372d6b, there *is* one test that fails if > you run make installcheck against a cluster running with -c > default_transaction_isolation=serializable: transaction.sql. Is that > a mistake? Is it a goal to be able to

Re: Regression tests vs SERIALIZABLE

2021-03-15 Thread Thomas Munro
On Mon, Mar 15, 2021 at 8:00 PM Bharath Rupireddy wrote: > Thanks. v2 LGTM, both make check and make check-world passes on my dev system. Pushed. Thanks!

Re: Regression tests vs SERIALIZABLE

2021-03-15 Thread Bharath Rupireddy
On Mon, Mar 15, 2021 at 11:04 AM Thomas Munro wrote: > > On Mon, Mar 15, 2021 at 6:14 PM Bharath Rupireddy > wrote: > > On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote: > > > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I > > > noticed that select_parallel.sql and write_p

Re: Regression tests vs SERIALIZABLE

2021-03-14 Thread Thomas Munro
On Mon, Mar 15, 2021 at 6:14 PM Bharath Rupireddy wrote: > On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote: > > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I > > noticed that select_parallel.sql and write_parallel.sql believe that > > (1) the tests are supposed to work wi

Re: Regression tests vs SERIALIZABLE

2021-03-14 Thread Bharath Rupireddy
On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote: > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I > noticed that select_parallel.sql and write_parallel.sql believe that > (1) the tests are supposed to work with serializable as a default > isolation level, and (2) parallelis