> On 9 Feb 2022, at 14:28, Andrew Dunstan wrote:
> On 2/9/22 08:11, Daniel Gustafsson wrote:
>> Good point, done in the attached.
>
> LGTM
Now that the recent changes to TAP and SSL tests have settled, I took another
pass at this. After rebasing and fixing and polishing and taking it for
multi
On 2/9/22 08:11, Daniel Gustafsson wrote:
>> On 8 Feb 2022, at 16:46, Andrew Dunstan wrote:
>> There a capitalization typo in SSL/Backend/OpenSSL.pm - looks like
>> that's my fault:
>>
>> + my $backend = SSL::backend::OpenSSL->new();
> Fixed.
>
>> Also, I think we should document that SSL::Serv
> On 8 Feb 2022, at 16:46, Andrew Dunstan wrote:
> There a capitalization typo in SSL/Backend/OpenSSL.pm - looks like
> that's my fault:
>
> + my $backend = SSL::backend::OpenSSL->new();
Fixed.
> Also, I think we should document that SSL::Server::new() takes an
> optional flavor parameter, in
On 2/8/22 09:24, Daniel Gustafsson wrote:
>
> The attached v2 takes a stab at fixing up the POD sections.
There a capitalization typo in SSL/Backend/OpenSSL.pm - looks like
that's my fault:
+ my $backend = SSL::backend::OpenSSL->new();
Also, I think we should document that SSL::Server::new
> On 7 Feb 2022, at 17:29, Andrew Dunstan wrote:
> On 2/2/22 14:50, Daniel Gustafsson wrote:
>>> On 2 Feb 2022, at 17:09, Andrew Dunstan wrote:
>>> On 2/2/22 08:26, Daniel Gustafsson wrote:
Thoughts? I'm fairly sure there are many crimes against Perl in this
patch,
I'm happy to
On 2/2/22 14:50, Daniel Gustafsson wrote:
>> On 2 Feb 2022, at 17:09, Andrew Dunstan wrote:
>> On 2/2/22 08:26, Daniel Gustafsson wrote:
>>> Thoughts? I'm fairly sure there are many crimes against Perl in this patch,
>>> I'm happy to take pointers on how to improve that.
>> It feels a bit odd to
> On 2 Feb 2022, at 17:09, Andrew Dunstan wrote:
> On 2/2/22 08:26, Daniel Gustafsson wrote:
>> Thoughts? I'm fairly sure there are many crimes against Perl in this patch,
>> I'm happy to take pointers on how to improve that.
>
> It feels a bit odd to me from a perl POV. I think it needs to mor
On 2/2/22 08:26, Daniel Gustafsson wrote:
> Thoughts? I'm fairly sure there are many crimes against Perl in this patch,
> I'm happy to take pointers on how to improve that.
It feels a bit odd to me from a perl POV. I think it needs to more along
the lines of standard OO patterns. I'll take a s
