On Thu, Oct 24, 2024 at 5:44 PM Peter Smith wrote:
>
> On Thu, Oct 24, 2024 at 5:41 PM Michael Paquier wrote:
> >
> > On Thu, Oct 24, 2024 at 05:27:25PM +1100, Peter Smith wrote:
> > > Yes, well spotted -- I was aware of that. Originally I had coded a >=
> > > PG15 check for that pub_names assign
On Fri, Oct 25, 2024 at 10:00 AM Michael Paquier wrote:
>
> On Fri, Oct 25, 2024 at 09:28:47AM +1100, Peter Smith wrote:
> > I've attached the patch v4.
>
> Looks OK to me. Thanks. I'll see to get that done through the day.
> --
Thanks for pushing!
==
Kind Regards,
Peter Smith.
Fujitsu Aus
On Fri, Oct 25, 2024 at 09:28:47AM +1100, Peter Smith wrote:
> I've attached the patch v4.
Looks OK to me. Thanks. I'll see to get that done through the day.
--
Michael
signature.asc
Description: PGP signature
On Thu, Oct 24, 2024 at 5:41 PM Michael Paquier wrote:
>
> On Thu, Oct 24, 2024 at 05:27:25PM +1100, Peter Smith wrote:
> > Yes, well spotted -- I was aware of that. Originally I had coded a >=
> > PG15 check for that pub_names assignment. e.g.
> >
> > if (walrcv_server_version(LogRepWorkerWalRcvC
On Thu, Oct 24, 2024 at 05:27:25PM +1100, Peter Smith wrote:
> Yes, well spotted -- I was aware of that. Originally I had coded a >=
> PG15 check for that pub_names assignment. e.g.
>
> if (walrcv_server_version(LogRepWorkerWalRcvConn) >= 15)
> GetPublicationsStr(MySubscription->publications
On Thu, Oct 24, 2024 at 3:17 PM Michael Paquier wrote:
>
> On Wed, Oct 23, 2024 at 03:40:19PM -0700, Masahiko Sawada wrote:
> > > Now, I've changed the function comment to:
> > > /*
> > > * Add a comma-separated list of publication names to the 'dest' string.
> > > */
> >
> > Thank you for updat
On Wed, Oct 23, 2024 at 03:40:19PM -0700, Masahiko Sawada wrote:
> > Now, I've changed the function comment to:
> > /*
> > * Add a comma-separated list of publication names to the 'dest' string.
> > */
>
> Thank you for updating the patch. The patch looks good to me.
+ /* Build the pub_names
On Thu, Oct 24, 2024 at 8:26 AM Masahiko Sawada wrote:
Thanks for your feedback!
>
> While the changes look good to me, the comment of GetPublicationsStr()
> seems not match what the function actually does:
>
> +/*
> + * Add publication names from the list to a string.
> + */
> +void
> +GetPubli
On Wed, Oct 23, 2024 at 3:26 PM Peter Smith wrote:
>
> On Thu, Oct 24, 2024 at 8:26 AM Masahiko Sawada wrote:
>
> Thanks for your feedback!
>
> >
> > While the changes look good to me, the comment of GetPublicationsStr()
> > seems not match what the function actually does:
> >
> > +/*
> > + * Add
On Wed, Oct 23, 2024 at 12:25 AM Peter Smith wrote:
>
> On Wed, Oct 23, 2024 at 5:23 PM Michael Paquier wrote:
> >
> > On Wed, Oct 23, 2024 at 03:44:03PM +1100, Peter Smith wrote:
> > > During a code review, it was noticed that there are several places
> > > within logical replication where a com
On Wed, Oct 23, 2024 at 5:23 PM Michael Paquier wrote:
>
> On Wed, Oct 23, 2024 at 03:44:03PM +1100, Peter Smith wrote:
> > During a code review, it was noticed that there are several places
> > within logical replication where a comma-separated list of publication
> > names is built explicitly. T
On Wed, Oct 23, 2024 at 03:44:03PM +1100, Peter Smith wrote:
> During a code review, it was noticed that there are several places
> within logical replication where a comma-separated list of publication
> names is built explicitly. There is already a utility function (called
> 'get_publications_str
12 matches
Mail list logo
