On Thu, Sep 29, 2022 at 10:35:20AM -0700, Nathan Bossart wrote:
> I've marked this one as ready-for-committer.
UnpinBuffer() is local to bufmgr.c, so it would not be an issue for
external code, and that's 10 callers that don't need to worry about
that anymore. 2d115e4 is from 2015, and nobody has
I've marked this one as ready-for-committer.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi Bharath,
> Also, it looks like changing the order of GetPrivateRefCountEntry()
> and ResourceOwnerForgetBuffer() doesn't have any effect as they are
> independent, but do we want to actually do that if there's no specific
> reason?
If we keep the order as it is now the code will become:
```
On Thu, Sep 29, 2022 at 1:52 PM Aleksander Alekseev
wrote:
>
> > Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
> > call to GetPrivateRefCountEntry()? From my quick skim of the code, it
> > seems like it should be safe, but I thought I'd ask the question.
> >
> > Same que
Nathan, Zhang,
Thanks for the review!
> Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
> call to GetPrivateRefCountEntry()? From my quick skim of the code, it
> seems like it should be safe, but I thought I'd ask the question.
>
> Same question, have a look, it doesn’t s
HI,
On Sep 29, 2022, 05:08 +0800, Nathan Bossart , wrote:
> On Wed, Sep 28, 2022 at 08:14:23PM +0300, Aleksander Alekseev wrote:
> > + ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
> > +
> > /* not moving as we're likely deleting it soon anyway */
> > ref = GetPrivateRefCountEntry(b, false);
On Wed, Sep 28, 2022 at 08:14:23PM +0300, Aleksander Alekseev wrote:
> + ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
> +
> /* not moving as we're likely deleting it soon anyway */
> ref = GetPrivateRefCountEntry(b, false);
> Assert(ref != NULL);
> -
> - i
