Re: Record SET session in VariableSetStmt

2022-10-06 Thread Julien Rouhaud
On Fri, Oct 07, 2022 at 10:30:28AM +0900, Michael Paquier wrote: > On Thu, Oct 06, 2022 at 08:28:27PM +0800, Julien Rouhaud wrote: > > If we move to a real jumbling of VariableSetStmt, we should keep the rules > > consistent with the rest of the jumble code and ignore an explicit > > "SESSION" in

Re: Record SET session in VariableSetStmt

2022-10-06 Thread Michael Paquier
On Thu, Oct 06, 2022 at 08:28:27PM +0800, Julien Rouhaud wrote: > If we move to a real jumbling of VariableSetStmt, we should keep the rules > consistent with the rest of the jumble code and ignore an explicit "SESSION" > in > the original command. Hm, interesting bit, I should study more this ar

Re: Record SET session in VariableSetStmt

2022-10-06 Thread Drouvot, Bertrand
On 10/6/22 2:28 PM, Julien Rouhaud wrote: On Thu, Oct 06, 2022 at 02:19:32PM +0200, Drouvot, Bertrand wrote: On 10/6/22 1:18 PM, Julien Rouhaud wrote: so nothing should rely on how exactly someone spelled it. This is also the case for our core jumbling code, where we guarantee (or at leas

Re: Record SET session in VariableSetStmt

2022-10-06 Thread Julien Rouhaud
On Thu, Oct 06, 2022 at 02:19:32PM +0200, Drouvot, Bertrand wrote: > > On 10/6/22 1:18 PM, Julien Rouhaud wrote: > > > so > > nothing should rely on how exactly someone spelled it. This is also the > > case > > for our core jumbling code, where we guarantee (or at least try to) that two > > seman

Re: Record SET session in VariableSetStmt

2022-10-06 Thread Drouvot, Bertrand
Hi, On 10/6/22 1:18 PM, Julien Rouhaud wrote: Hi, On Thu, Oct 06, 2022 at 12:57:17PM +0200, Drouvot, Bertrand wrote: Hi hackers, "SET local" is currently recorded in VariableSetStmt (with the boolean is_local) but "SET session" is not. Please find attached a patch proposal to also record "SE

Re: Record SET session in VariableSetStmt

2022-10-06 Thread Julien Rouhaud
Hi, On Thu, Oct 06, 2022 at 12:57:17PM +0200, Drouvot, Bertrand wrote: > Hi hackers, > > "SET local" is currently recorded in VariableSetStmt (with the boolean > is_local) but "SET session" is not. > > Please find attached a patch proposal to also record "SET session" so that > VariableSetStmt rec