Re: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-03-06 Thread Alvaro Herrera
Craig Ringer wrote: > Revised patch attached. > > I have _not_ rewritten to use sscanf yet. I'll do that next, so you can > choose the fewer-changes patch for backpatching if desired. Pushed, with a further change: it seems more sensible to centralize the whole operation of building the path, ra

Re: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-03-06 Thread Craig Ringer
On 6 March 2018 at 16:07, Craig Ringer wrote: > On 6 March 2018 at 09:58, Craig Ringer wrote: > >> On 5 March 2018 at 23:25, David Steele wrote: >> >>> Hi Craig, >>> >>> On 1/21/18 5:45 PM, Craig Ringer wrote: >>> > On 6 January 2018 at 08:28, Alvaro Herrera >> >

Re: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-03-06 Thread Craig Ringer
On 6 March 2018 at 09:58, Craig Ringer wrote: > On 5 March 2018 at 23:25, David Steele wrote: > >> Hi Craig, >> >> On 1/21/18 5:45 PM, Craig Ringer wrote: >> > On 6 January 2018 at 08:28, Alvaro Herrera > > > wrote: >> > >> > I think this should use ReadDirExt

Re: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-03-05 Thread Craig Ringer
On 5 March 2018 at 23:25, David Steele wrote: > Hi Craig, > > On 1/21/18 5:45 PM, Craig Ringer wrote: > > On 6 January 2018 at 08:28, Alvaro Herrera > > wrote: > > > > I think this should use ReadDirExtended with an elevel less than > ERROR, > > and do not

Re: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-03-05 Thread David Steele
Hi Craig, On 1/21/18 5:45 PM, Craig Ringer wrote: > On 6 January 2018 at 08:28, Alvaro Herrera > wrote: > > I think this should use ReadDirExtended with an elevel less than ERROR, > and do nothing. > > Why have strcmp(.) and strcmp(..)?  These are goi